From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F9FC32C33A; Mon, 27 Oct 2025 18:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590672; cv=none; b=Pjys/IdrvrF5oXbB0O3wmH9pNju/Lp9x0qC6z2D5VYZNWBX278vfjHoflezldJJRPkehhAjY8DIBXKEkB2IN97YkXCO3kFhMqRZSgCA3XhwxSC/cIVI5C6y8IxCRQRxBEi7V+DdeVYCdH+vjc1FotLci9UxhFkDJasTeb5SVEQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590672; c=relaxed/simple; bh=WJU30gO6W3kNaTGBwVkW6239xs1cFPm9FiMhSPS+Y6U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BucrjYQAlL2w/Sw1FC9dZGmUSWWlVuRpm7OeZLP7EUGpe4xVMKh7FwZwlv8SINWVITrYOPxbUhqomonszUdr/VMl865BKSfh9cpw3HzTm2ol09V6+i3rZM76HR681uVkea2TuGlV+S5/SOL6RlmaxYrCoqu+U/HP1c8Rt2YdemA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=elzGT9z7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="elzGT9z7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2356C113D0; Mon, 27 Oct 2025 18:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761590672; bh=WJU30gO6W3kNaTGBwVkW6239xs1cFPm9FiMhSPS+Y6U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=elzGT9z7hd5OcpBiMk7Oxy1amD1KzXXaph0v1xM+UjoKY9zZ85Q7BVEogsOK2Qtxr WJ3oXhZIgAVARNM6R8h2Xx4czPMAbcVa1kDCKvGrECSji6l5MtWWycsHWnk6MbYsfC vMdJcAaDeSUcSIZQJeZilQW8UjpQLRQuVeTdnmeU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Carlo Caione , Johan Hovold , Martin Blumenstingl , Neil Armstrong Subject: [PATCH 5.4 104/224] firmware: meson_sm: fix device leak at probe Date: Mon, 27 Oct 2025 19:34:10 +0100 Message-ID: <20251027183511.772135336@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183508.963233542@linuxfoundation.org> References: <20251027183508.963233542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 8ece3173f87df03935906d0c612c2aeda9db92ca upstream. Make sure to drop the reference to the secure monitor device taken by of_find_device_by_node() when looking up its driver data on behalf of other drivers (e.g. during probe). Note that holding a reference to the platform device does not prevent its driver data from going away so there is no point in keeping the reference after the helper returns. Fixes: 8cde3c2153e8 ("firmware: meson_sm: Rework driver as a proper platform driver") Cc: stable@vger.kernel.org # 5.5 Cc: Carlo Caione Signed-off-by: Johan Hovold Acked-by: Martin Blumenstingl Link: https://lore.kernel.org/r/20250725074019.8765-1-johan@kernel.org Signed-off-by: Neil Armstrong Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/meson/meson_sm.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/drivers/firmware/meson/meson_sm.c +++ b/drivers/firmware/meson/meson_sm.c @@ -223,11 +223,16 @@ EXPORT_SYMBOL(meson_sm_call_write); struct meson_sm_firmware *meson_sm_get(struct device_node *sm_node) { struct platform_device *pdev = of_find_device_by_node(sm_node); + struct meson_sm_firmware *fw; if (!pdev) return NULL; - return platform_get_drvdata(pdev); + fw = platform_get_drvdata(pdev); + + put_device(&pdev->dev); + + return fw; } EXPORT_SYMBOL_GPL(meson_sm_get);