From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4BCD32549B; Mon, 27 Oct 2025 19:26:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761593170; cv=none; b=q5TEAO/J6Ha/wUlO5MW6TLUz43ugeKhUTXAk//eRYATGtyEPkRQ1nYM7BkCRN0UP3NKHfkIm5R0Gsr105YdtulxAQZhlQdBB49fnwNJwJPFomaoxSVHKwz8Q2kP01Za1jvGMWfnGCfFKeaS90RIrP8R/2c10LN/vz+HfLvN/1fc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761593170; c=relaxed/simple; bh=EIE6ceYDkHtE3ln8Q6c988U1l4syhrkQ+bDlNcp1PCw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RKZ4TBZ+TWjunuo4behpO9W1juMYk7nEf3MUOnEu+v/OB4nf48yyIC/hTSlqyrdgMV+5HEfsqoEdZFpXqCTNKZIspEVptcM0JYxmMrOeSWrwSQYI9vsqnYB8qKtvAQ5Fut5x7zn0lB4fYLdAiyUz+lUdSbHLL/Ns2hdi3Z/rWuc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TMA494YW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TMA494YW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3517AC4CEF1; Mon, 27 Oct 2025 19:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761593169; bh=EIE6ceYDkHtE3ln8Q6c988U1l4syhrkQ+bDlNcp1PCw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TMA494YW3JEEzC3iUl7lz2leoYbktrRQa9ziJKXyog8jWzqUFGLbR/5eXVcx6G9fW jKNgW+KQ5R76K7P+D0GNjSQ9lDYVxecsBxWcc3dv7WuxAdC2nCQtAzacB6LBN1vyr5 dB4AmoreNKciuc0S8Txfg6rqDYEOBuFT+Mq4yHRo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ioana Ciornei , Mathew McBride , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.17 040/184] dpaa2-eth: fix the pointer passed to PTR_ALIGN on Tx path Date: Mon, 27 Oct 2025 19:35:22 +0100 Message-ID: <20251027183515.989888182@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183514.934710872@linuxfoundation.org> References: <20251027183514.934710872@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ioana Ciornei [ Upstream commit 902e81e679d86846a2404630d349709ad9372d0d ] The blamed commit increased the needed headroom to account for alignment. This means that the size required to always align a Tx buffer was added inside the dpaa2_eth_needed_headroom() function. By doing that, a manual adjustment of the pointer passed to PTR_ALIGN() was no longer correct since the 'buffer_start' variable was already pointing to the start of the skb's memory. The behavior of the dpaa2-eth driver without this patch was to drop frames on Tx even when the headroom was matching the 128 bytes necessary. Fix this by removing the manual adjust of 'buffer_start' from the PTR_MODE call. Closes: https://lore.kernel.org/netdev/70f0dcd9-1906-4d13-82df-7bbbbe7194c6@app.fastmail.com/T/#u Fixes: f422abe3f23d ("dpaa2-eth: increase the needed headroom to account for alignment") Signed-off-by: Ioana Ciornei Tested-by: Mathew McBride Reviewed-by: Simon Horman Link: https://patch.msgid.link/20251016135807.360978-1-ioana.ciornei@nxp.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c index 0f4efd5053320..a5f3d19f1466c 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -1077,8 +1077,7 @@ static int dpaa2_eth_build_single_fd(struct dpaa2_eth_priv *priv, dma_addr_t addr; buffer_start = skb->data - dpaa2_eth_needed_headroom(skb); - aligned_start = PTR_ALIGN(buffer_start - DPAA2_ETH_TX_BUF_ALIGN, - DPAA2_ETH_TX_BUF_ALIGN); + aligned_start = PTR_ALIGN(buffer_start, DPAA2_ETH_TX_BUF_ALIGN); if (aligned_start >= skb->head) buffer_start = aligned_start; else -- 2.51.0