From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3418832B9B0; Mon, 27 Oct 2025 19:28:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761593335; cv=none; b=UZDfL3NIzKYzXJPYehWuaq6EOHj2n5L0yDX40JYauYTyGmsKEqsWsRohtWVwDDKuhhUNpe/7y9Y9iP5bAfuceLz5KDi5Uiv0NTGTz26d2Bc8WcL61UKfX/a8LDCaO7LRtgq1Q4ekYkEIEpTkD4brpMpihWNGRXpD5nD4QDf9mUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761593335; c=relaxed/simple; bh=rJif1dTCiVz/fJ8Wp6UdfHHWkpevy2qTadosuxUfnz8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=t0VXrsBiAM27Lp+FSSk/PlhQrbof9sg80XW2UhNpsWcgn2nGYoE8gEJRefrOi7+hX/PkEweva2LhY7j/XHEryMxS4Dj7kT5YLoTY9i7PUnzu6Spkyv44adjKRzrC/dVN601GceBNRi1/0NR0SbM7HFwfUee0dHYVp5JxAx13iYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=T5cSuJcM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="T5cSuJcM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7DF7C113D0; Mon, 27 Oct 2025 19:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761593335; bh=rJif1dTCiVz/fJ8Wp6UdfHHWkpevy2qTadosuxUfnz8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T5cSuJcMmkZOV3DccQa7PCkLMbipC5RwSpH6vtDd7QYqbFWUSTdXtX9/ABE7pQvm6 aJqYAHDn5dut4hlYHfNUrwV3EE7KGIUWxVvQgr6cGBRX4KSPxM0IqV0foCUpQ0ps5f RylqJF6izNsFCE2c/NoM8tstYvlIGvldAJMTs7F0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fabrizio Castro , Lad Prabhakar , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Jakub Kicinski Subject: [PATCH 6.17 100/184] net: ravb: Ensure memory write completes before ringing TX doorbell Date: Mon, 27 Oct 2025 19:36:22 +0100 Message-ID: <20251027183517.606263831@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183514.934710872@linuxfoundation.org> References: <20251027183514.934710872@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lad Prabhakar commit 706136c5723626fcde8dd8f598a4dcd251e24927 upstream. Add a final dma_wmb() barrier before triggering the transmit request (TCCR_TSRQ) to ensure all descriptor and buffer writes are visible to the DMA engine. According to the hardware manual, a read-back operation is required before writing to the doorbell register to guarantee completion of previous writes. Instead of performing a dummy read, a dma_wmb() is used to both enforce the same ordering semantics on the CPU side and also to ensure completion of writes. Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") Cc: stable@vger.kernel.org Co-developed-by: Fabrizio Castro Signed-off-by: Fabrizio Castro Signed-off-by: Lad Prabhakar Reviewed-by: Niklas Söderlund Link: https://patch.msgid.link/20251017151830.171062-5-prabhakar.mahadev-lad.rj@bp.renesas.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/renesas/ravb_main.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -2231,6 +2231,14 @@ static netdev_tx_t ravb_start_xmit(struc dma_wmb(); desc->die_dt = DT_FSINGLE; } + + /* Before ringing the doorbell we need to make sure that the latest + * writes have been committed to memory, otherwise it could delay + * things until the doorbell is rang again. + * This is in replacement of the read operation mentioned in the HW + * manuals. + */ + dma_wmb(); ravb_modify(ndev, TCCR, TCCR_TSRQ0 << q, TCCR_TSRQ0 << q); priv->cur_tx[q] += num_tx_desc;