From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC77F1DDC1B; Mon, 27 Oct 2025 19:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761593344; cv=none; b=l2LoEfW6IOPiMTdBGv4t5z2M4RhSNv2n+4krJ+xzlHmAhVrQHIZLb6a1Saxq2UEfnqFNDgFoXdXn1QuzvwvqEMK7LWRjlvzSj327hI23kotg8MJ0K5FLyOLUIdxzYXwyULScfrEJ9FjKyXPFEJy8plbEy/izA/yWNsSQVnQhr1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761593344; c=relaxed/simple; bh=JU7bvz01YUebkjHpNO+a/GA1VjiuSv89OjEqrVgnXFM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VoM/q4sFNDhXyFVT1jnG57TeA5To4ia3PmGTf7vxWOyEpCdFRB6RyfhV5O06FqV9eSKp9P+cd28cVmNmkjhw/ULd6muYWn5Y6tC7HRfs5E/Gq7y7HwxzKgAK4lDHGktXTB2eFOa+En4jez81hO6RfsDSEogIivdlr/gVEqPFXvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bXSNcRz9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bXSNcRz9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5642C4CEF1; Mon, 27 Oct 2025 19:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761593344; bh=JU7bvz01YUebkjHpNO+a/GA1VjiuSv89OjEqrVgnXFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bXSNcRz9xXxCBXKrvlB+siC5VPlJfivTXO5P8lve4D0wRIVdBlf34KWJTGJU6Raeb bVG/ZRRo6Mp6B5ZBpRL7U/CQXIWxpNpZm5xEoB8ZB2ReR6FQtMS4hYfqkABP0k+i2B Qd0JRWxSfxt0dui+icApn+TMg358BCx+26Des9u4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Geliang Tang , "Matthieu Baerts (NGI0)" , Jakub Kicinski Subject: [PATCH 6.17 103/184] selftests: mptcp: join: mark implicit tests as skipped if not supported Date: Mon, 27 Oct 2025 19:36:25 +0100 Message-ID: <20251027183517.689060666@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183514.934710872@linuxfoundation.org> References: <20251027183514.934710872@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Matthieu Baerts (NGI0) commit 973f80d715bd2504b4db6e049f292e694145cd79 upstream. The call to 'continue_if' was missing: it properly marks a subtest as 'skipped' if the attached condition is not valid. Without that, the test is wrongly marked as passed on older kernels. Fixes: 36c4127ae8dd ("selftests: mptcp: join: skip implicit tests if not supported") Cc: stable@vger.kernel.org Reviewed-by: Geliang Tang Signed-off-by: Matthieu Baerts (NGI0) Link: https://patch.msgid.link/20251020-net-mptcp-c-flag-late-add-addr-v1-3-8207030cb0e8@kernel.org Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- tools/testing/selftests/net/mptcp/mptcp_join.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -3751,7 +3751,7 @@ endpoint_tests() # subflow_rebuild_header is needed to support the implicit flag # userspace pm type prevents add_addr if reset "implicit EP" && - mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then + continue_if mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then pm_nl_set_limits $ns1 2 2 pm_nl_set_limits $ns2 2 2 pm_nl_add_endpoint $ns1 10.0.2.1 flags signal @@ -3776,7 +3776,7 @@ endpoint_tests() fi if reset_with_tcp_filter "delete and re-add" ns2 10.0.3.2 REJECT OUTPUT && - mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then + continue_if mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then start_events pm_nl_set_limits $ns1 0 3 pm_nl_set_limits $ns2 0 3