From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A11E32D7D7; Mon, 27 Oct 2025 18:53:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591234; cv=none; b=j6wqIp7A9nKPuVFu0dhlWppx2s9+BQKmfRgtAG05w/ZtxAWTNRxjsaTqGHFAdpkyb4kcV5RkDiQkfTWpcoYTb8FIAQpm1EVIgBayqXzwmWyjDwjvXDeTwpunmalw4Q9M91QoR4J1xYu+rbo2XsNP0+PCVTkM5KZZQsTuY5SwtW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591234; c=relaxed/simple; bh=qs5syYPp8HnnhcBCjrdOhgCD8AG3x7A6a02DmFVTJZk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tLPpet69Yrn026tbXH3NzLUlggBQDpxBr/PCEqfRb2JE4nAF7ngBH26Ou3UHse7PotJF4T8G+3qg4NvTNMZRdwGFy59YLD0CYZJnCYnJ6iUyHjsFOD5hT0rk7qHk172nQXEtG7FSjXZyoP7DwH2fYlrNxyRYjkB+35TgVbhMGns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NIMfNMD+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NIMfNMD+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C27DCC113D0; Mon, 27 Oct 2025 18:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761591234; bh=qs5syYPp8HnnhcBCjrdOhgCD8AG3x7A6a02DmFVTJZk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NIMfNMD+WUV/Z7tJIqoKEJM0MPNEW8x7jcLC7NgRubsd6K/0O/E61o6m5UuYM240s pLFqdppCaCAabcit2p5gXYdHeDZOgCCtIPLRgtArAYGWbz+3+66OsS7mSa5WrgSQen z0H9y0U+SS/ISsSyTLjhwFjWfCANXOsxAEfOqIfQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Michal Pecio , I Viswanath , Jakub Kicinski , Sasha Levin , syzbot+78cae3f37c62ad092caa@syzkaller.appspotmail.com Subject: [PATCH 5.10 079/332] net: usb: Remove disruptive netif_wake_queue in rtl8150_set_multicast Date: Mon, 27 Oct 2025 19:32:12 +0100 Message-ID: <20251027183526.706351389@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183524.611456697@linuxfoundation.org> References: <20251027183524.611456697@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: I Viswanath [ Upstream commit 958baf5eaee394e5fd976979b0791a875f14a179 ] syzbot reported WARNING in rtl8150_start_xmit/usb_submit_urb. This is the sequence of events that leads to the warning: rtl8150_start_xmit() { netif_stop_queue(); usb_submit_urb(dev->tx_urb); } rtl8150_set_multicast() { netif_stop_queue(); netif_wake_queue(); <-- wakes up TX queue before URB is done } rtl8150_start_xmit() { netif_stop_queue(); usb_submit_urb(dev->tx_urb); <-- double submission } rtl8150_set_multicast being the ndo_set_rx_mode callback should not be calling netif_stop_queue and notif_start_queue as these handle TX queue synchronization. The net core function dev_set_rx_mode handles the synchronization for rtl8150_set_multicast making it safe to remove these locks. Reported-and-tested-by: syzbot+78cae3f37c62ad092caa@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=78cae3f37c62ad092caa Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Tested-by: Michal Pecio Signed-off-by: I Viswanath Link: https://patch.msgid.link/20250924134350.264597-1-viswanathiyyappan@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/usb/rtl8150.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index acef52b0729bf..c0f5e8ab1e34e 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c @@ -664,7 +664,6 @@ static void rtl8150_set_multicast(struct net_device *netdev) rtl8150_t *dev = netdev_priv(netdev); u16 rx_creg = 0x9e; - netif_stop_queue(netdev); if (netdev->flags & IFF_PROMISC) { rx_creg |= 0x0001; dev_info(&netdev->dev, "%s: promiscuous mode\n", netdev->name); @@ -678,7 +677,6 @@ static void rtl8150_set_multicast(struct net_device *netdev) rx_creg &= 0x00fc; } async_set_registers(dev, RCR, sizeof(rx_creg), rx_creg); - netif_wake_queue(netdev); } static netdev_tx_t rtl8150_start_xmit(struct sk_buff *skb, -- 2.51.0