From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF84B321445; Mon, 27 Oct 2025 18:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591145; cv=none; b=XnAsddiO6VWfdfYEJBHP5ottrodOPl4F/q5UIHsD1hNyPYMbeE409Z/kXhKHnJyKhZLVrZKv7mUZKGDHJmTDao3DRZwz+hCnZXixe9AxXFLe9yR2lAGM6IXtSKOBh1fUZ7ujtL1G9gLd6hTUQUCLPJIVptOq0RwEXLc2woYluew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591145; c=relaxed/simple; bh=ed7ccSi5A6Ru1CpO8vumFnimajvu/j6huvvWGc82uZA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BXcN7NXkHa0I8J5IkiXe4xE8K32Ur7f9BiGErCLVMivhIg8t4V/ZE/qlGm2ZKDtWkmfwvI+lvDroNuf8NLce2ltthHrSu6tVRhjXkA1D+z+6oj4yxF8Tt6ny80p0V8ukhsx1hr7wIIMWWfhWg0DcR6maD1pfNUxx+gEdNRjYS+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=G/uaTiYv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="G/uaTiYv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30FA0C4CEF1; Mon, 27 Oct 2025 18:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761591145; bh=ed7ccSi5A6Ru1CpO8vumFnimajvu/j6huvvWGc82uZA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G/uaTiYvdQ7+Y5X6VT7DCRvaLwacdOWlo2HpNJ4x0FuFjc7WwgqjvRdSoPwIx98iX 2QQs7Xke6/oussIVGvuXvdW9JEonWbxrVbvTLuZAuH9XF9QQE68/cKdgI7j9kRJZ6f m8ppdU8MCOJfLnlXHG3SVcXdxVOQkdliQ2tpBk2A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kohei Enju , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 085/332] net: ena: return 0 in ena_get_rxfh_key_size() when RSS hash key is not configurable Date: Mon, 27 Oct 2025 19:32:18 +0100 Message-ID: <20251027183526.866346909@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183524.611456697@linuxfoundation.org> References: <20251027183524.611456697@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kohei Enju [ Upstream commit f017156aea60db8720e47591ed1e041993381ad2 ] In EC2 instances where the RSS hash key is not configurable, ethtool shows bogus RSS hash key since ena_get_rxfh_key_size() unconditionally returns ENA_HASH_KEY_SIZE. Commit 6a4f7dc82d1e ("net: ena: rss: do not allocate key when not supported") added proper handling for devices that don't support RSS hash key configuration, but ena_get_rxfh_key_size() has been unchanged. When the RSS hash key is not configurable, return 0 instead of ENA_HASH_KEY_SIZE to clarify getting the value is not supported. Tested on m5 instance families. Without patch: # ethtool -x ens5 | grep -A 1 "RSS hash key" RSS hash key: 00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00 With patch: # ethtool -x ens5 | grep -A 1 "RSS hash key" RSS hash key: Operation not supported Fixes: 6a4f7dc82d1e ("net: ena: rss: do not allocate key when not supported") Signed-off-by: Kohei Enju Link: https://patch.msgid.link/20250929050247.51680-1-enjuk@amazon.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c b/drivers/net/ethernet/amazon/ena/ena_ethtool.c index 3b2cd28f962de..7f4e11fea180f 100644 --- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c +++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c @@ -681,7 +681,10 @@ static u32 ena_get_rxfh_indir_size(struct net_device *netdev) static u32 ena_get_rxfh_key_size(struct net_device *netdev) { - return ENA_HASH_KEY_SIZE; + struct ena_adapter *adapter = netdev_priv(netdev); + struct ena_rss *rss = &adapter->ena_dev->rss; + + return rss->hash_key ? ENA_HASH_KEY_SIZE : 0; } static int ena_indirection_table_set(struct ena_adapter *adapter, -- 2.51.0