From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB4BF32B996; Mon, 27 Oct 2025 18:53:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591192; cv=none; b=VUeikqW2wt39KrqjB8IiK1kiZxrL0LIsDIjYlm91rfyZMDa59itDs0ISFhUjtwQJqXZ7xKVHkstjnuO6UJK48X0NnGQLbV+9JWXdFcBuDQot5ioD9t416lfOUblphdKUDNfvM4omkHr6XMoDCgFSK1tbSkfnE4DSi5aenGo4TZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591192; c=relaxed/simple; bh=bBpGL2hhKqZ214RLIJitIqs7QeW19S0UNhkgdiCqZSs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KzHMo+WanONZA4iG8UovBfIwF1FMC7ggM2OwXq71SG/rvBXaJeSapk6vhbswSLh/pCMNuThG6QECsJqwEkY2qFaYhgdqbz9SMQdBOJ6FsDnvFC/4OzJOvdZBcmlvj2Ku/nyczU+4+1c1mJgdllzqo2do65dZq/gi2O1NdOJAVsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=g9xt4i1r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="g9xt4i1r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18AAFC4CEFD; Mon, 27 Oct 2025 18:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761591192; bh=bBpGL2hhKqZ214RLIJitIqs7QeW19S0UNhkgdiCqZSs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g9xt4i1rkyLVzek9MXvO6e4nEundYmPJTKlB5PxvaHat0RUYQ+a86/Otx1hauPQ1r 9LWZENIKCF/kEdw8fhSE+nJb0EnG14clqsLhQqE1qqtTcOGliipdLOBC1Y5IusH4c+ 7KBtw9ZbEno1kYdKZdnf+yZmcLjltRblOmSchFbQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ian Rogers , Yunseong Kim , Adrian Hunter , Alexander Shishkin , Jiri Olsa , Kan Liang , Namhyung Kim , Stephen Brennan , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 5.10 101/332] perf util: Fix compression checks returning -1 as bool Date: Mon, 27 Oct 2025 19:32:34 +0100 Message-ID: <20251027183527.285478060@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183524.611456697@linuxfoundation.org> References: <20251027183524.611456697@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yunseong Kim [ Upstream commit 43fa1141e2c1af79c91aaa4df03e436c415a6fc3 ] The lzma_is_compressed and gzip_is_compressed functions are declared to return a "bool" type, but in case of an error (e.g., file open failure), they incorrectly returned -1. A bool type is a boolean value that is either true or false. Returning -1 for a bool return type can lead to unexpected behavior and may violate strict type-checking in some compilers. Fix the return value to be false in error cases, ensuring the function adheres to its declared return type improves for preventing potential bugs related to type mismatch. Fixes: 4b57fd44b61beb51 ("perf tools: Add lzma_is_compressed function") Reviewed-by: Ian Rogers Signed-off-by: Yunseong Kim Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Kan Liang Cc: Namhyung Kim Cc: Stephen Brennan Link: https://lore.kernel.org/r/20250822162506.316844-3-ysk@kzalloc.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/lzma.c | 2 +- tools/perf/util/zlib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/lzma.c b/tools/perf/util/lzma.c index 51424cdc3b682..aa9a0ebc1f937 100644 --- a/tools/perf/util/lzma.c +++ b/tools/perf/util/lzma.c @@ -115,7 +115,7 @@ bool lzma_is_compressed(const char *input) ssize_t rc; if (fd < 0) - return -1; + return false; rc = read(fd, buf, sizeof(buf)); close(fd); diff --git a/tools/perf/util/zlib.c b/tools/perf/util/zlib.c index 78d2297c1b674..1f7c065230599 100644 --- a/tools/perf/util/zlib.c +++ b/tools/perf/util/zlib.c @@ -88,7 +88,7 @@ bool gzip_is_compressed(const char *input) ssize_t rc; if (fd < 0) - return -1; + return false; rc = read(fd, buf, sizeof(buf)); close(fd); -- 2.51.0