From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 832CE3128D5; Mon, 27 Oct 2025 18:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591247; cv=none; b=B+lTnGT8K6nVFwsIAb9qX1zCqbA3ed3U+jkbtjkbminh1MYDOIAQNVQxJaHHD/1No6RgkB+CDp+R9G0mx0XpDBc7c/iNz/HRChmxJNYgJ1o/UCvhKy7vTtNqjiTOafvfG6M9e/8CZAcAtsnwkIcqZMzZeyaywQFEgXgo4ZhSsBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591247; c=relaxed/simple; bh=T1219g+8EIPQDNtnE1k6klGgUlp5SEr3L/fdjwYfTjU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dmEcS1gulxF5S44zVX38DIAihuRaUGUxJzcN7XkuCt2uJFQBPwIXeTuGTiSOhnyVuQfMajeOzfNidz5nC8fcHgu5LSWEondgcdBnEEM0CL/1pCXufgUjcQqcriidxNRcB0ME4JdE1UOnnxA0UXtjSA+xK0XGOIzwwA4abLBTgqY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=i7F9Im4W; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="i7F9Im4W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC6BEC4CEF1; Mon, 27 Oct 2025 18:54:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761591247; bh=T1219g+8EIPQDNtnE1k6klGgUlp5SEr3L/fdjwYfTjU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i7F9Im4WSNg0EAhLSX8vSMK4GOY24UWKXUSquHygF8jVXZyXpgViX1KNCVztBnog5 y+ee/KvTGoaARKxIw/JKQPe+1JLAUkxw1QxWu4Y8n6ovwcje051m0UrkMkKKGuZrvZ 98j/bqVVas9OrytnE+aFvBSdOUVmE7yfNk4NeLmk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gunnar Kudrjavets , Justinien Bouron , Jarkko Sakkinen , Paul Menzel , Sasha Levin Subject: [PATCH 5.10 124/332] tpm_tis: Fix incorrect arguments in tpm_tis_probe_irq_single Date: Mon, 27 Oct 2025 19:32:57 +0100 Message-ID: <20251027183527.885891952@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183524.611456697@linuxfoundation.org> References: <20251027183524.611456697@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gunnar Kudrjavets [ Upstream commit 8a81236f2cb0882c7ea6c621ce357f7f3f601fe5 ] The tpm_tis_write8() call specifies arguments in wrong order. Should be (data, addr, value) not (data, value, addr). The initial correct order was changed during the major refactoring when the code was split. Fixes: 41a5e1cf1fe1 ("tpm/tpm_tis: Split tpm_tis driver into a core and TCG TIS compliant phy") Signed-off-by: Gunnar Kudrjavets Reviewed-by: Justinien Bouron Reviewed-by: Jarkko Sakkinen Reviewed-by: Paul Menzel Signed-off-by: Jarkko Sakkinen Signed-off-by: Sasha Levin --- drivers/char/tpm/tpm_tis_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c index b3452259d6e0b..c8c68301543b2 100644 --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -831,8 +831,8 @@ static int tpm_tis_probe_irq_single(struct tpm_chip *chip, u32 intmask, * will call disable_irq which undoes all of the above. */ if (!(chip->flags & TPM_CHIP_FLAG_IRQ)) { - tpm_tis_write8(priv, original_int_vec, - TPM_INT_VECTOR(priv->locality)); + tpm_tis_write8(priv, TPM_INT_VECTOR(priv->locality), + original_int_vec); rc = -1; } -- 2.51.0