From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0F2132C323; Mon, 27 Oct 2025 18:56:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591418; cv=none; b=G6ocYpiwEshUV8d40HYJSv8vmyds7QfN+MZeIqnv20svCHOKc3YkBzat02j4qZduX81YmejVQU8uIZ56b8aAJvfEVJ7o56OIjdOyiTrWDUVtNADOKCYDUNJFcfSdRJZvovDE5X4pqA9V/JCT1rnEDpf92mMnHJN3e1oKY/PMk08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591418; c=relaxed/simple; bh=NraJihS+0bV6NmQwg2AfwECykZXMJXXzodd3FnUnOrk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LoX+5dINF93MqbxPBHWDn138Lel91eKVwnxKcah9JPiLNJBy3MGUm/SHSJbfBjrlBswvpEug67BeGy/cEEPdfrdygXrcTbIZeCMymaDGYsIvUnHEeYeD4yql9CKoBKem3f7WA/n/BD6FoEIW1maUCBKZPLtbg23OgF6A/jYV9Bk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Wr9Hr+P2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Wr9Hr+P2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE71BC4CEF1; Mon, 27 Oct 2025 18:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761591418; bh=NraJihS+0bV6NmQwg2AfwECykZXMJXXzodd3FnUnOrk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wr9Hr+P2WbrEHQfB/+CYORodJ6v0q2tlGv2SCEPshOdYBfJsgYMdVDILYPgnrX0Yi YSdYB8DM3dZPC6tMI3RzzPBM72rbbft2YfpoCDDLRTHTT/CY8NGSLgMdFQ5zNQgNR4 lQ0YhM9OK2MIHOkeRE206ExqrEpZ+Kqa1z7oBsTg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Niklas Schnelle , Bjorn Helgaas , Lukas Wunner Subject: [PATCH 5.10 159/332] PCI/AER: Fix missing uevent on recovery when a reset is requested Date: Mon, 27 Oct 2025 19:33:32 +0100 Message-ID: <20251027183528.826902591@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183524.611456697@linuxfoundation.org> References: <20251027183524.611456697@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Niklas Schnelle commit bbf7d0468d0da71d76cc6ec9bc8a224325d07b6b upstream. Since commit 7b42d97e99d3 ("PCI/ERR: Always report current recovery status for udev") AER uses the result of error_detected() as parameter to pci_uevent_ers(). As pci_uevent_ers() however does not handle PCI_ERS_RESULT_NEED_RESET this results in a missing uevent for the beginning of recovery if drivers request a reset. Fix this by treating PCI_ERS_RESULT_NEED_RESET as beginning recovery. Fixes: 7b42d97e99d3 ("PCI/ERR: Always report current recovery status for udev") Signed-off-by: Niklas Schnelle Signed-off-by: Bjorn Helgaas Reviewed-by: Lukas Wunner Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20250807-add_err_uevents-v5-1-adf85b0620b0@linux.ibm.com Signed-off-by: Greg Kroah-Hartman --- drivers/pci/pci-driver.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -1546,6 +1546,7 @@ void pci_uevent_ers(struct pci_dev *pdev switch (err_type) { case PCI_ERS_RESULT_NONE: case PCI_ERS_RESULT_CAN_RECOVER: + case PCI_ERS_RESULT_NEED_RESET: envp[idx++] = "ERROR_EVENT=BEGIN_RECOVERY"; envp[idx++] = "DEVICE_ONLINE=0"; break;