From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9927320A02; Mon, 27 Oct 2025 18:56:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591390; cv=none; b=RDRTaGvroRnyW0MdDVGdodhTycfsbTlYyQqWuEEhCz1SH/Yxgle5dhzZe+9lQUHhPnmLysnzT3KEj2CGKwFcIynG4QKePQ6xpj4e+9Oq7jWWdSB5amvZnGa2yNdh+MzH1/Yfgjq3D2X/sOjeXvGeLTEAtHVszQkMIyV+Nl9aL8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591390; c=relaxed/simple; bh=fRF1hyMzmA/02wz83tcAzczg8Dv0PrmPg4SOJSPjXd0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pAHuOsYt6tqp8nI6GL52eazyoXFHFFuMwraEQxTzZg/JSosAXhjvv9Dax0h74jlq86T1Av5qgXBpAC4Qqs1+j848OglMb/ddne5TzsMzUzQVPr8cNCTLoRnwov5919/U6nZV/Cg8HosSkejyE/qptbQZK2bo7rbij61+hRwg+io= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JZPaYnJ2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JZPaYnJ2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D51FC4CEF1; Mon, 27 Oct 2025 18:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761591389; bh=fRF1hyMzmA/02wz83tcAzczg8Dv0PrmPg4SOJSPjXd0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JZPaYnJ2HbWKV0IGmSxxlmnbyI2ZjQS0t6Hq8Ib6jY5aisbhz2nZj9KI28tR7S0Ht 7ioCoDbUl9PJr7+Er1QHxhODkediKRi6Z58fa8yS+R3NgYGbAwaY/pP6TebNyh+fwo /hQ7UP9WfrDTN0yvNeVGrl0CsusE+sltBQ+lWkp8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+031d0cfd7c362817963f@syzkaller.appspotmail.com, Edward Adam Davis , Sakari Ailus , Hans Verkuil , Sasha Levin Subject: [PATCH 5.10 178/332] media: mc: Clear minor number before put device Date: Mon, 27 Oct 2025 19:33:51 +0100 Message-ID: <20251027183529.351761032@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183524.611456697@linuxfoundation.org> References: <20251027183524.611456697@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Edward Adam Davis [ Upstream commit 8cfc8cec1b4da88a47c243a11f384baefd092a50 ] The device minor should not be cleared after the device is released. Fixes: 9e14868dc952 ("media: mc: Clear minor number reservation at unregistration time") Cc: stable@vger.kernel.org Reported-by: syzbot+031d0cfd7c362817963f@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=031d0cfd7c362817963f Tested-by: syzbot+031d0cfd7c362817963f@syzkaller.appspotmail.com Signed-off-by: Edward Adam Davis Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil [ moved clear_bit from media_devnode_release callback to media_devnode_unregister before put_device ] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/media/mc/mc-devnode.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) --- a/drivers/media/mc/mc-devnode.c +++ b/drivers/media/mc/mc-devnode.c @@ -50,11 +50,6 @@ static void media_devnode_release(struct { struct media_devnode *devnode = to_media_devnode(cd); - mutex_lock(&media_devnode_lock); - /* Mark device node number as free */ - clear_bit(devnode->minor, media_devnode_nums); - mutex_unlock(&media_devnode_lock); - /* Release media_devnode and perform other cleanups as needed. */ if (devnode->release) devnode->release(devnode); @@ -283,6 +278,7 @@ void media_devnode_unregister(struct med /* Delete the cdev on this minor as well */ cdev_device_del(&devnode->cdev, &devnode->dev); devnode->media_dev = NULL; + clear_bit(devnode->minor, media_devnode_nums); mutex_unlock(&media_devnode_lock); put_device(&devnode->dev);