From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89BD0317711; Mon, 27 Oct 2025 18:57:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591456; cv=none; b=J3EcwwcUzhC06LGBU3AezfSCQ7UsYxCjqS/a22dlNTUajzTY1pT4J3au9TeShbO8Bp8hcTMcir/7EcjqXucJuHNa0ruTIxoEtJQfl1fSvGAmgR9zhgNEse7JC5Vp7qplrY0mFhMw2f+6S+g3+AK7WpPT9BWPXVmm/teGtL9SVtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591456; c=relaxed/simple; bh=iEUOzPONXz4AljFDjP39+eow2miuUQ7YHMPC8QVz3u8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UiJ9x0rS3YYH/rLfr03R8efwe152wBLjDtG2IFP92/H505U6zrohIgPEehnc3ZreXofS7wxbaKO6HE080+hSLTt8/I610Vi9ZcqOricYg8dWruMk4hmKa3GHvXNfO4oIzrCbNeKa83SX1d4ta1tdfoZ1aBfs1CMsApeOD9659ak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=seGv3J9p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="seGv3J9p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2D41C4CEF1; Mon, 27 Oct 2025 18:57:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761591456; bh=iEUOzPONXz4AljFDjP39+eow2miuUQ7YHMPC8QVz3u8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=seGv3J9pmVuxnktqrgbE5MWSRPZTRiSGVx6XCAgiTMHGXTELl0yMAE5UMoinUM46T Gbp+wJSNaeDXpSJxmHYsKs/85V1OrBevSYzJOphDRy+Fw6kK9HzWbyQd7z9PfYXIdN 1vsjiZXjIJacw3jTCgb31f1fCxJDzlmHDQckIJLg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Laight , Andy Shevchenko , Christoph Hellwig , "Jason A. Donenfeld" , Linus Torvalds , "Matthew Wilcox (Oracle)" , Andrew Morton , Eliav Farber Subject: [PATCH 5.10 204/332] minmax: allow comparisons of int against unsigned char/short Date: Mon, 27 Oct 2025 19:34:17 +0100 Message-ID: <20251027183530.108982525@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183524.611456697@linuxfoundation.org> References: <20251027183524.611456697@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Laight [ Upstream commit 4ead534fba42fc4fd41163297528d2aa731cd121 ] Since 'unsigned char/short' get promoted to 'signed int' it is safe to compare them against an 'int' value. Link: https://lkml.kernel.org/r/8732ef5f809c47c28a7be47c938b28d4@AcuMS.aculab.com Signed-off-by: David Laight Cc: Andy Shevchenko Cc: Christoph Hellwig Cc: Jason A. Donenfeld Cc: Linus Torvalds Cc: Matthew Wilcox (Oracle) Signed-off-by: Andrew Morton Signed-off-by: Eliav Farber Signed-off-by: Greg Kroah-Hartman --- include/linux/minmax.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/include/linux/minmax.h +++ b/include/linux/minmax.h @@ -26,8 +26,9 @@ __builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \ is_signed_type(typeof(x)), 0) -#define __types_ok(x, y) \ - (__is_signed(x) == __is_signed(y)) +#define __types_ok(x, y) \ + (__is_signed(x) == __is_signed(y) || \ + __is_signed((x) + 0) == __is_signed((y) + 0)) #define __cmp_op_min < #define __cmp_op_max >