From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DBCE331A5E; Mon, 27 Oct 2025 18:59:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591554; cv=none; b=auII4UCHEzw38wpOrtFZX6qGcZxtWFVOv948CwI5t+mIgrfZ6avB35Y1Y2CdAsnKTLkhVpQgS6lfsrgVuwpu3x9zRh3qb3mwQ9JhltBKe/b+g8WybXYkn2AimgndnrANsLtEJAezmduawjLb/LYkJHaCnJz6GrvbfX6pRWp/yCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591554; c=relaxed/simple; bh=MjC8wMJV17x1xC4zCSdEOGUpUt7HPIosnTVHzbbJteQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mFPrCCRwnfTnVzGF9G7jWPMUopJucJDkNba+CBhk2JeQhzf42TYdzMH+UzESUqeC0H7jbDSuQUdbObQExPMzphM/QRUFYHZZ7jPIcHr7T6Ntok8qXq6rR8y8+iXcle43XB9qnJfs7wAc4gSp9nmWMOaerJUhTturrEoFzO3Jpf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yOMh8XdO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yOMh8XdO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3D42C4CEF1; Mon, 27 Oct 2025 18:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761591554; bh=MjC8wMJV17x1xC4zCSdEOGUpUt7HPIosnTVHzbbJteQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yOMh8XdOzPC7n1QLPgs0HUBovqXTvsJ/5iQtbfdWYWTzttSDMp0HPuG9rAMJcqv4r r6p01U/yPTuU3C3lNFOyYTNEyjYl0fLTe1bpjvI2pBsv9hGNFBOskKxBBOmlL1JCPd 3d8KZrX+3cwXa9wq/sf1WHltOHb0kL/G37bHdf5c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Linmao Li , Jacob Keller , Heiner Kallweit , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 242/332] r8169: fix packet truncation after S4 resume on RTL8168H/RTL8111H Date: Mon, 27 Oct 2025 19:34:55 +0100 Message-ID: <20251027183531.223931226@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183524.611456697@linuxfoundation.org> References: <20251027183524.611456697@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Linmao Li [ Upstream commit 70f92ab97042f243e1c8da1c457ff56b9b3e49f1 ] After resume from S4 (hibernate), RTL8168H/RTL8111H truncates incoming packets. Packet captures show messages like "IP truncated-ip - 146 bytes missing!". The issue is caused by RxConfig not being properly re-initialized after resume. Re-initializing the RxConfig register before the chip re-initialization sequence avoids the truncation and restores correct packet reception. This follows the same pattern as commit ef9da46ddef0 ("r8169: fix data corruption issue on RTL8402"). Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E") Signed-off-by: Linmao Li Reviewed-by: Jacob Keller Reviewed-by: Heiner Kallweit Link: https://patch.msgid.link/20251009122549.3955845-1-lilinmao@kylinos.cn Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/realtek/r8169_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index b60add52f4497..9fb8fdd5b2619 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -4979,8 +4979,9 @@ static int __maybe_unused rtl8169_resume(struct device *device) if (!device_may_wakeup(tp_to_dev(tp))) clk_prepare_enable(tp->clk); - /* Reportedly at least Asus X453MA truncates packets otherwise */ - if (tp->mac_version == RTL_GIGA_MAC_VER_37) + /* Some chip versions may truncate packets without this initialization */ + if (tp->mac_version == RTL_GIGA_MAC_VER_37 || + tp->mac_version == RTL_GIGA_MAC_VER_46) rtl_init_rxcfg(tp); return rtl8169_net_resume(tp); -- 2.51.0