From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9447325C810; Mon, 27 Oct 2025 19:00:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591640; cv=none; b=rUEUh61FB2MJxqbsCjHzog93IGjlKT1MK6aIuz0gG9FmvnxftSJS893MEg7P8MSttsooMqbv7CPVqjLA0SEyRqkHjBlIDvevpfleXUfcooiewqIIM8sClCkIP++tUQ/qqDa/5A293QdsflJl3XIsvVSIx6uP1sho/iSHlh56mcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591640; c=relaxed/simple; bh=sEkngEuj/glDIV0Lpu9AQS7r1MraXx7h38mijQbBNoA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XKxL30K0fNOBG56qrX/IZf+t8As7pjkKlWcM2OgNPVV0Ht8DW0YUBCiWvGsvszdS5bWqrwx89hW5cu/T3uYN2HS2g/j2viiSH3StTtlj/2kVkesOSz9ld4staFQ/aY+dyNOPMzVICUTsEb69vUSKqzOEE2YfTiso/Xr84av/lFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pptZZf7d; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pptZZf7d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28DA9C4CEF1; Mon, 27 Oct 2025 19:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761591640; bh=sEkngEuj/glDIV0Lpu9AQS7r1MraXx7h38mijQbBNoA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pptZZf7dQLzOIIj8NPVARk8oTXRn2K0Wb7oHJ9H7sVUdfGru/MPwKRfeGH/4HLYc9 TTY2cjOemJzkeevGVSpAQ/t8lD4sbija/pyfIOPmZEYUVTqbgAunvZkH0Z1k8Fw3K1 2c3vLumXryd8rb++8bX7Z35mgTxh5Hu7eF8YEuQ8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Michael=20Wei=C3=9F?= , Harshal Gohel , =?UTF-8?q?Johannes=20Wiesb=C3=B6ck?= , Ido Schimmel , Nikolay Aleksandrov , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 275/332] rtnetlink: Allow deleting FDB entries in user namespace Date: Mon, 27 Oct 2025 19:35:28 +0100 Message-ID: <20251027183532.123437183@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183524.611456697@linuxfoundation.org> References: <20251027183524.611456697@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johannes Wiesböck [ Upstream commit bf29555f5bdc017bac22ca66fcb6c9f46ec8788f ] Creating FDB entries is possible from a non-initial user namespace when having CAP_NET_ADMIN, yet, when deleting FDB entries, processes receive an EPERM because the capability is always checked against the initial user namespace. This restricts the FDB management from unprivileged containers. Drop the netlink_capable check in rtnl_fdb_del as it was originally dropped in c5c351088ae7 and reintroduced in 1690be63a27b without intention. This patch was tested using a container on GyroidOS, where it was possible to delete FDB entries from an unprivileged user namespace and private network namespace. Fixes: 1690be63a27b ("bridge: Add vlan support to static neighbors") Reviewed-by: Michael Weiß Tested-by: Harshal Gohel Signed-off-by: Johannes Wiesböck Reviewed-by: Ido Schimmel Reviewed-by: Nikolay Aleksandrov Link: https://patch.msgid.link/20251015201548.319871-1-johannes.wiesboeck@aisec.fraunhofer.de Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/core/rtnetlink.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 42c97a71174fe..0b44c6b1ef999 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -4152,9 +4152,6 @@ static int rtnl_fdb_del(struct sk_buff *skb, struct nlmsghdr *nlh, int err; u16 vid; - if (!netlink_capable(skb, CAP_NET_ADMIN)) - return -EPERM; - if (!del_bulk) { err = nlmsg_parse_deprecated(nlh, sizeof(*ndm), tb, NDA_MAX, NULL, extack); -- 2.51.0