From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EEF82F8BD1; Mon, 27 Oct 2025 19:03:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591785; cv=none; b=u6s5RYh0EDHFSy8U5CoLeFQtfaX9O0pKbduEHN2iTGD/wSpIzZnGb7Gl8xZP/tAtzoquhg4EbHCnz+9K+cFPVgGRNgs/2QtOO2KjV2q8WfW0Asin3qjQRBxvQXU2PI7AWSkjSir0+a2NdUFtcLLj3HXbmPcu2iTs6nSjPxnFO1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761591785; c=relaxed/simple; bh=1b9thl9ghh5YWJz4rKdfbM6pAfaWY3jhCh40zr4kdAI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=as4aGNG5mdUSIwz0FrGEuHh4toTEIpKAMGNh1zoJrg7JmfOf1Gnaj/zdxKwh5uJHqbjabP3+42CnrCi6j2JJhJZHhqKuK+pIXaq2LaSnoCukmNkp8uthiB3PWHNK12SRPCFwJbpcEZTOUVOfEUgiMVEb0830QMX5dmgf/Pp+wt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iuu+/Zwl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iuu+/Zwl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B70D6C4CEF1; Mon, 27 Oct 2025 19:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761591785; bh=1b9thl9ghh5YWJz4rKdfbM6pAfaWY3jhCh40zr4kdAI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iuu+/ZwlR9RsQep7M9IXfL5oZsmNEOOjIgHXZ+swiP8nGL5J7/7w5KIkttItD5dld 5BdRqykv8e30o8MVHWCZAUeZ9/iOiDO67uq2JwpyUS2CNTaOlF2yuXNFuSVWmolXY/ GwfsTYo06RfQgpcoT9/bKrGW2Mdv5sRkMHxOSN7U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Kaushlendra Kumar , Sudeep Holla , Sasha Levin Subject: [PATCH 5.10 329/332] arch_topology: Fix incorrect error check in topology_parse_cpu_capacity() Date: Mon, 27 Oct 2025 19:36:22 +0100 Message-ID: <20251027183533.579869547@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183524.611456697@linuxfoundation.org> References: <20251027183524.611456697@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kaushlendra Kumar [ Upstream commit 2eead19334516c8e9927c11b448fbe512b1f18a1 ] Fix incorrect use of PTR_ERR_OR_ZERO() in topology_parse_cpu_capacity() which causes the code to proceed with NULL clock pointers. The current logic uses !PTR_ERR_OR_ZERO(cpu_clk) which evaluates to true for both valid pointers and NULL, leading to potential NULL pointer dereference in clk_get_rate(). Per include/linux/err.h documentation, PTR_ERR_OR_ZERO(ptr) returns: "The error code within @ptr if it is an error pointer; 0 otherwise." This means PTR_ERR_OR_ZERO() returns 0 for both valid pointers AND NULL pointers. Therefore !PTR_ERR_OR_ZERO(cpu_clk) evaluates to true (proceed) when cpu_clk is either valid or NULL, causing clk_get_rate(NULL) to be called when of_clk_get() returns NULL. Replace with !IS_ERR_OR_NULL(cpu_clk) which only proceeds for valid pointers, preventing potential NULL pointer dereference in clk_get_rate(). Cc: stable Signed-off-by: Kaushlendra Kumar Reviewed-by: Sudeep Holla Fixes: b8fe128dad8f ("arch_topology: Adjust initial CPU capacities with current freq") Link: https://patch.msgid.link/20250923174308.1771906-1-kaushlendra.kumar@intel.com Signed-off-by: Greg Kroah-Hartman [ Adjust context ] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/base/arch_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/base/arch_topology.c +++ b/drivers/base/arch_topology.c @@ -196,7 +196,7 @@ bool __init topology_parse_cpu_capacity( * frequency (by keeping the initial freq_factor value). */ cpu_clk = of_clk_get(cpu_node, 0); - if (!PTR_ERR_OR_ZERO(cpu_clk)) { + if (!IS_ERR_OR_NULL(cpu_clk)) { per_cpu(freq_factor, cpu) = clk_get_rate(cpu_clk) / 1000; clk_put(cpu_clk);