From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F15D2AE8D; Tue, 11 Nov 2025 00:51:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762822290; cv=none; b=QGcbx+y5kt7wveCxVyyscziQ6LJSK/2KyisJTv3accY5qPCZozn4GSBU5MNSiIgyw+j1JNvWZbZd10n7AudZkWCQOodEsXkF1wja9W1hvVnF1i8HHLvZ/t2zymP/Z/Uq428u9KGyn9ue2Hz7q76A9lJtGyZYtf6sqRuqXbU6xzM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762822290; c=relaxed/simple; bh=xKVKudnfb0CS3YoOePYnqv2cL1YyReHD9t293nmhl1A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tkthZcV2mB55LDuJb3mqJ2MBw9Se3NYIiu9AzHc0PdjlnNedKS9w30b3CWEs3fM4OgbQIGifYhJyphflV8CD5alTCu9EyFcS8THkcl06WdV+WTjbtXWzAXKSWIxiFCPI6lSIEbjnKETXCRPyg9DypNqYBmnb7gWpoi42umHqYFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iU6uEtu0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iU6uEtu0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A59AAC116B1; Tue, 11 Nov 2025 00:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1762822289; bh=xKVKudnfb0CS3YoOePYnqv2cL1YyReHD9t293nmhl1A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iU6uEtu00MfyroP0kZiCqgH8WvbNoFD+eF1PeljZNF0m5ahUvu/R2bMBeXabd8rr6 LPpQ5iML6QG09Hs+2ETVPH+ity9pJK9Tx0zfFWDQcKsyJpLzcMGLggPld94C8cZaSN KR/LvpmMzK+vWbRYtobZOERQ2WBWYjuHHQPn5j+A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jeff Johnson , Loic Poulain , Baochen Qiang , Sasha Levin Subject: [PATCH 6.12 019/565] wifi: ath10k: Fix memory leak on unsupported WMI command Date: Tue, 11 Nov 2025 09:37:55 +0900 Message-ID: <20251111004527.302767099@linuxfoundation.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251111004526.816196597@linuxfoundation.org> References: <20251111004526.816196597@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Loic Poulain [ Upstream commit 2e9c1da4ee9d0acfca2e0a3d78f3d8cb5802da1b ] ath10k_wmi_cmd_send takes ownership of the passed buffer (skb) and has the responsibility to release it in case of error. This patch fixes missing free in case of early error due to unhandled WMI command ID. Tested-on: WCN3990 hw1.0 WLAN.HL.3.3.7.c2-00931-QCAHLSWMTPLZ-1 Fixes: 553215592f14 ("ath10k: warn if give WMI command is not supported") Suggested-by: Jeff Johnson Signed-off-by: Loic Poulain Reviewed-by: Baochen Qiang Link: https://patch.msgid.link/20250926195656.187970-1-loic.poulain@oss.qualcomm.com Signed-off-by: Jeff Johnson Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath10k/wmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index fdab67a56e438..32754f894f0b0 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -1937,6 +1937,7 @@ int ath10k_wmi_cmd_send(struct ath10k *ar, struct sk_buff *skb, u32 cmd_id) if (cmd_id == WMI_CMD_UNSUPPORTED) { ath10k_warn(ar, "wmi command %d is not supported by firmware\n", cmd_id); + dev_kfree_skb_any(skb); return ret; } -- 2.51.0