From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DD3335C1B2; Wed, 3 Dec 2025 16:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764780213; cv=none; b=pDO63cIdtQxyizLmGYNoOgO5dW8k/ejKoXAY8iXVW2i6MzRvyzaX2QO0vjoXTMJs+3Zfr/tz63/iVMnVDJMCLfBBVAzfuTc7cg83rCH5PEDPJkMQwYl6vrd/a44gfSpM2zJhgk5FzeTTWn6WqluI9uFfbUUPPg02w12RPL1EKEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764780213; c=relaxed/simple; bh=fSZ7THvPpiygu2IYWURCIOreVR95JbKES8572pb2kyc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Kyvz2Vonu/Lwj10FcBCyJRgp9iL1ekVbbuRiT5pgjBHySPRuqoFNzsG6/K2qxVhVPrfh2BpZzKO+3d2sEZwqnLZZoLkwJxUxJUJeAIJ7eerKmBKRSVJ/Qno5b9H1YG8p4T6j5i7vA8ocjJrRtpS8VJ34p7gYFjhGPJekkwXwaFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LW1D5A6v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LW1D5A6v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2A0EC4CEF5; Wed, 3 Dec 2025 16:43:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764780212; bh=fSZ7THvPpiygu2IYWURCIOreVR95JbKES8572pb2kyc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LW1D5A6vjIV33dbC5g8bal/mbtXwmSlsGP5XRl7N8No8feYHdK5MBcfC77xzvDUdB yTU0AeV7+aqV9Ewue7CHWzryZOOl1bXwAUlDrjXcX3mMbdtafOsNFijnMwunITShT7 kr4psttQM6OW2/VmnT+kRV+RZIAJ9NCaUabfPKIw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Peter Griffin , Krzysztof Kozlowski , =?UTF-8?q?Andr=C3=A9=20Draszik?= , Marek Szyprowski , Ulf Hansson , Sasha Levin Subject: [PATCH 6.1 488/568] pmdomain: samsung: plug potential memleak during probe Date: Wed, 3 Dec 2025 16:28:10 +0100 Message-ID: <20251203152458.579432661@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152440.645416925@linuxfoundation.org> References: <20251203152440.645416925@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: André Draszik [ Upstream commit 90c82941adf1986364e0f82c35cf59f2bf5f6a1d ] of_genpd_add_provider_simple() could fail, in which case this code leaks the domain name, pd->pd.name. Use devm_kstrdup_const() to plug this leak. As a side-effect, we can simplify existing error handling. Fixes: c09a3e6c97f0 ("soc: samsung: pm_domains: Convert to regular platform driver") Cc: stable@vger.kernel.org Reviewed-by: Peter Griffin Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik Tested-by: Marek Szyprowski Signed-off-by: Ulf Hansson [ drivers/pmdomain/samsung/exynos-pm-domains.c -> drivers/soc/samsung/pm_domains.c ] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/soc/samsung/pm_domains.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) --- a/drivers/soc/samsung/pm_domains.c +++ b/drivers/soc/samsung/pm_domains.c @@ -91,13 +91,14 @@ static const struct of_device_id exynos_ { }, }; -static const char *exynos_get_domain_name(struct device_node *node) +static const char *exynos_get_domain_name(struct device *dev, + struct device_node *node) { const char *name; if (of_property_read_string(node, "label", &name) < 0) name = kbasename(node->full_name); - return kstrdup_const(name, GFP_KERNEL); + return devm_kstrdup_const(dev, name, GFP_KERNEL); } static int exynos_pd_probe(struct platform_device *pdev) @@ -114,15 +115,13 @@ static int exynos_pd_probe(struct platfo if (!pd) return -ENOMEM; - pd->pd.name = exynos_get_domain_name(np); + pd->pd.name = exynos_get_domain_name(dev, np); if (!pd->pd.name) return -ENOMEM; pd->base = of_iomap(np, 0); - if (!pd->base) { - kfree_const(pd->pd.name); + if (!pd->base) return -ENODEV; - } pd->pd.power_off = exynos_pd_power_off; pd->pd.power_on = exynos_pd_power_on;