From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D35483314B4; Tue, 16 Dec 2025 11:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765884935; cv=none; b=HR2O8AiJGHu8+vUF+Y1bL8sanInQ8Da9zbx4LACt5Jj/xze7yOeFkP+Sf/34ErQN67wMtxWnFyRAcbMurgrpM5tNbZ40VzosokjphN5m/606UQW7kYafWqvxCazLOUoGDmM7TQ8TZIqLazR6rEyp6+CIw+i4ypJpA8bjhg+u79Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765884935; c=relaxed/simple; bh=wlp1adIMctO7MtwdVez3TTuqpOtMI20rqTTyCgDoMk4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=opUiJ/MJglF3WvQ9tc7+qBLgXC+86qwX8JmtrlVL8rpXoVIZlgzTgQ0JYgUWAEiTMH/kreJXDosqo1XG1XGjuiRlyb0LS1F9UH1ERHzaCySjBzGnhsoemFfT8qTu2S2wdOHbxKj1+LX/eBgDjECL0r//4tOg78MbuvOodqpvVzQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0tl/m0Xf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0tl/m0Xf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3706FC4CEF1; Tue, 16 Dec 2025 11:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765884935; bh=wlp1adIMctO7MtwdVez3TTuqpOtMI20rqTTyCgDoMk4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0tl/m0XfL/aKzEeH16tchgN48FIOwEHXfcmIC8NykdboRZcro9RE9eUzzgfFKTGd9 d54t9/5tZcfVUeEQV6XnINHuOfuV60T0SgQNX1AtvQ+qgLLohITFDJBAWzrhGoRd+K ku8wNh4kpLIiTIJij42kF2B3FOZH5IDuFCnBggZ8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Duoming Zhou , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 6.12 343/354] scsi: imm: Fix use-after-free bug caused by unfinished delayed work Date: Tue, 16 Dec 2025 12:15:10 +0100 Message-ID: <20251216111333.331348853@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251216111320.896758933@linuxfoundation.org> References: <20251216111320.896758933@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Duoming Zhou [ Upstream commit ab58153ec64fa3fc9aea09ca09dc9322e0b54a7c ] The delayed work item 'imm_tq' is initialized in imm_attach() and scheduled via imm_queuecommand() for processing SCSI commands. When the IMM parallel port SCSI host adapter is detached through imm_detach(), the imm_struct device instance is deallocated. However, the delayed work might still be pending or executing when imm_detach() is called, leading to use-after-free bugs when the work function imm_interrupt() accesses the already freed imm_struct memory. The race condition can occur as follows: CPU 0(detach thread) | CPU 1 | imm_queuecommand() | imm_queuecommand_lck() imm_detach() | schedule_delayed_work() kfree(dev) //FREE | imm_interrupt() | dev = container_of(...) //USE dev-> //USE Add disable_delayed_work_sync() in imm_detach() to guarantee proper cancellation of the delayed work item before imm_struct is deallocated. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Duoming Zhou Link: https://patch.msgid.link/20251028100149.40721-1-duoming@zju.edu.cn Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/imm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c index 1d4c7310f1a63..d77490e2d7bc8 100644 --- a/drivers/scsi/imm.c +++ b/drivers/scsi/imm.c @@ -1261,6 +1261,7 @@ static void imm_detach(struct parport *pb) imm_struct *dev; list_for_each_entry(dev, &imm_hosts, list) { if (dev->dev->port == pb) { + disable_delayed_work_sync(&dev->imm_tq); list_del_init(&dev->list); scsi_remove_host(dev->host); scsi_host_put(dev->host); -- 2.51.0