From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40F0E3446AB; Tue, 16 Dec 2025 11:44:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765885486; cv=none; b=LsUnUvmV0MXs1xiUVUj0NLcp9Vg6iGFhOtF7+DHzUDyZjqTbriVIq9prCdGUMr14nP7cq9fuYlAasulRJStpBz6ziot54D0iR/mMDnj25SmF0Pz5poNSKRRrAgBsurCSqecsuaE1/yIXW/Z163BpnwEQOwjUIhkttwzN+lOtk1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765885486; c=relaxed/simple; bh=Ho+xxAukhMPJJ0QLSBfPdqsdU9Z60l5GrtL7Sx0wo0A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OiJLby9unTcHR0JtvaQBbjdEk3Il6/mIrXGHTsMHZgZRgr8MbVW9Aa6UJIZaebt21Q+HNyiH96jPGOl/JyIsYS9MdBBjKPaMVUqzE6+fH5SwL9bw3OiKD6yzTJXZ4Xgs1RBw9fLeRXe6LkE7ktNgi8t6C915IaUy6PQndGTNGuc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aIHGenU9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aIHGenU9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D05DC4CEF1; Tue, 16 Dec 2025 11:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765885486; bh=Ho+xxAukhMPJJ0QLSBfPdqsdU9Z60l5GrtL7Sx0wo0A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aIHGenU9wLCsDvjUZSaKe6uHgdsTk7pwNI5y3KpxkGTX38hOOPHgiMKNILiNRi4Jw SonPSDAY/92ASp6xsWMRqCW2dDO6yi75pTthtlEUKhouO2s5aL6huHP+XvjqQJOc6g bus8opfgnOObRbdSSPul1+kGpoC6hCQCfALNoU80= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ivan Abramov , Sebastian Reichel , Sasha Levin Subject: [PATCH 6.17 153/507] power: supply: cw2015: Check devm_delayed_work_autocancel() return code Date: Tue, 16 Dec 2025 12:09:54 +0100 Message-ID: <20251216111351.067933095@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251216111345.522190956@linuxfoundation.org> References: <20251216111345.522190956@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ivan Abramov [ Upstream commit 92ec7e7b86ec0aff9cd7db64d9dce50a0ea7c542 ] Since devm_delayed_work_autocancel() may fail, add return code check and exit cw_bat_probe() on error. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 0cb172a4918e ("power: supply: cw2015: Use device managed API to simplify the code") Signed-off-by: Ivan Abramov Link: https://patch.msgid.link/20251008120711.556021-1-i.abramov@mt-integration.ru Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/cw2015_battery.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c index 382dff8805c62..f41ce7e41fac9 100644 --- a/drivers/power/supply/cw2015_battery.c +++ b/drivers/power/supply/cw2015_battery.c @@ -702,7 +702,13 @@ static int cw_bat_probe(struct i2c_client *client) if (!cw_bat->battery_workqueue) return -ENOMEM; - devm_delayed_work_autocancel(&client->dev, &cw_bat->battery_delay_work, cw_bat_work); + ret = devm_delayed_work_autocancel(&client->dev, &cw_bat->battery_delay_work, cw_bat_work); + if (ret) { + dev_err_probe(&client->dev, ret, + "Failed to register delayed work\n"); + return ret; + } + queue_delayed_work(cw_bat->battery_workqueue, &cw_bat->battery_delay_work, msecs_to_jiffies(10)); return 0; -- 2.51.0