From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Maciej Strozek <mstrozek@opensource.cirrus.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>,
yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com,
ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
ckeepax@opensource.cirrus.com, mac.chiang@intel.com,
naveen.m@intel.com
Subject: [PATCH AUTOSEL 6.18] ASoC: sof_sdw: Add a quirk for Lenovo laptop using sidecar amps with cs42l43
Date: Mon, 9 Feb 2026 07:26:51 -0500 [thread overview]
Message-ID: <20260209122714.1037915-12-sashal@kernel.org> (raw)
In-Reply-To: <20260209122714.1037915-1-sashal@kernel.org>
From: Maciej Strozek <mstrozek@opensource.cirrus.com>
[ Upstream commit 1425900231372acf870dd89e8d3bb4935f7f0c81 ]
Add a quirk for a Lenovo laptop (SSID: 0x17aa3821) to allow using sidecar
CS35L57 amps with CS42L43 codec.
Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20260128092410.1540583-1-mstrozek@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
LLM Generated explanations, may be completely bogus:
## Analysis
### Commit Message Analysis
This commit adds a hardware quirk (PCI SSID entry) for a specific Lenovo
laptop (SSID: 0x17aa3821) to enable sidecar CS35L57 amplifiers with the
CS42L43 codec. The commit message is straightforward and describes a
device-specific quirk addition.
### Code Change Analysis
The change is a **single line addition**:
```c
SND_PCI_QUIRK(0x17aa, 0x3821, "Lenovo 0x3821", SOC_SDW_SIDECAR_AMPS),
```
This adds an entry to the `sof_sdw_ssid_quirk_table[]` array, which is a
table of PCI subsystem ID quirks. The entry maps a specific Lenovo
laptop's subsystem ID (vendor 0x17aa, device 0x3821) to the
`SOC_SDW_SIDECAR_AMPS` quirk flag.
### Classification: Hardware Quirk / Device ID Addition
This falls squarely into the **QUIRKS and WORKAROUNDS** exception
category for stable backports:
- It's a hardware-specific quirk for a specific laptop model
- It uses an existing mechanism (`SND_PCI_QUIRK` macro,
`sof_sdw_ssid_quirk_table`)
- It adds to an existing table with similar entries already present
- The quirk flag `SOC_SDW_SIDECAR_AMPS` already exists and is used by
the driver
### Risk Assessment
- **Scope**: Single line, single file change
- **Risk**: Extremely low — only affects the specific Lenovo laptop with
SSID 0x17aa:0x3821
- **Side effects**: None for any other hardware; the quirk is matched by
PCI subsystem ID
- **Dependencies**: The `SOC_SDW_SIDECAR_AMPS` flag and the quirk
infrastructure must exist in the stable tree
### User Impact
Without this quirk, owners of this specific Lenovo laptop would have
non-functional or incorrectly configured audio (the sidecar amplifiers
wouldn't be recognized/used). This is a real hardware enablement issue —
the laptop's speakers likely don't work properly without this quirk.
### Stability Indicators
- **Reviewed-by**: Cezary Rojewski (Intel audio maintainer)
- **Signed-off-by**: Mark Brown (ASoC subsystem maintainer)
- This is a well-understood, minimal pattern used extensively in audio
drivers
### Concerns
- The `SOC_SDW_SIDECAR_AMPS` quirk flag must exist in the target stable
tree. This flag and the cs42l43 sidecar amp support may be relatively
new, so it may only apply to recent stable branches (e.g., 6.12.y or
later). If the flag doesn't exist in older stable trees, the patch
simply won't apply, which is safe.
- No other dependencies — this is a self-contained table entry addition.
### Verdict
This is a textbook stable-worthy hardware quirk addition: a single-line
entry in an existing quirk table, enabling audio hardware on a specific
laptop model. It has zero risk to other hardware, is reviewed by
subsystem maintainers, and fixes a real user-facing problem (broken
audio).
**YES**
sound/soc/intel/boards/sof_sdw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c
index c013e31d098e7..198858b57d9f5 100644
--- a/sound/soc/intel/boards/sof_sdw.c
+++ b/sound/soc/intel/boards/sof_sdw.c
@@ -794,6 +794,7 @@ static const struct snd_pci_quirk sof_sdw_ssid_quirk_table[] = {
SND_PCI_QUIRK(0x17aa, 0x2347, "Lenovo P16", SOC_SDW_CODEC_MIC),
SND_PCI_QUIRK(0x17aa, 0x2348, "Lenovo P16", SOC_SDW_CODEC_MIC),
SND_PCI_QUIRK(0x17aa, 0x2349, "Lenovo P1", SOC_SDW_CODEC_MIC),
+ SND_PCI_QUIRK(0x17aa, 0x3821, "Lenovo 0x3821", SOC_SDW_SIDECAR_AMPS),
{}
};
--
2.51.0
next prev parent reply other threads:[~2026-02-09 12:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 12:26 [PATCH AUTOSEL 6.18-6.12] drm/amd/display: extend delta clamping logic to CM3 LUT helper Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18] io_uring/fdinfo: be a bit nicer when looping a lot of SQEs/CQEs Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.12] ALSA: hda/realtek: Enable headset mic for Acer Nitro 5 Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-5.10] platform/x86: classmate-laptop: Add missing NULL pointer checks Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.6] platform/x86/amd/pmc: Add quirk for MECHREVO Wujie 15X Pro Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.6] ASoC: amd: yc: Add quirk for HP 200 G2a 16 Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-5.15] platform/x86: panasonic-laptop: Fix sysfs group leak in error path Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-5.15] ASoC: fsl_xcvr: fix missing lock in fsl_xcvr_mode_put() Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.12] tracing/dma: Cap dma_map_sg tracepoint arrays to prevent buffer overflow Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-5.10] drm/tegra: hdmi: sor: Fix error: variable ‘j’ set but not used Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.1] ASoC: Intel: sof_es8336: Add DMI quirk for Huawei BOD-WXX9 Sasha Levin
2026-02-09 12:26 ` Sasha Levin [this message]
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-5.10] gpiolib: acpi: Fix gpio count with string references Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.6] ASoC: cs42l43: Correct handling of 3-pole jack load detection Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.12] drm/amd/display: remove assert around dpp_base replacement Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260209122714.1037915-12-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=mac.chiang@intel.com \
--cc=mstrozek@opensource.cirrus.com \
--cc=naveen.m@intel.com \
--cc=patches@lists.linux.dev \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox