[PATCH AUTOSEL 6.18-6.12] drm/amd/display: remove assert around dpp_base replacement

[Sasha Levin <sashal@kernel.org>]

From: Melissa Wen <mwen@igalia.com>

[ Upstream commit 84962445cd8a83dc5bed4c8ad5bbb2c1cdb249a0 ]

There is nothing wrong if in_shaper_func type is DISTRIBUTED POINTS.
Remove the assert placed for a TODO to avoid misinterpretations.

Signed-off-by: Melissa Wen <mwen@igalia.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 1714dcc4c2c53e41190896eba263ed6328bcf415)
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

### Critical Finding

`ASSERT(false)` expands to `WARN_ON_ONCE(!(false))` which is
`WARN_ON_ONCE(true)`. This means **every time** this code path is hit on
a production kernel, it will generate a `WARN_ON_ONCE` — producing a
full stack trace in the kernel log and potentially triggering panic-on-
warn configurations.

This is a real bug for users who:
1. Have DCN 3.2 hardware (AMD display controllers)
2. Use color management features where `in_shaper_func.type ==
   TF_TYPE_DISTRIBUTED_POINTS`
3. Run kernels with `panic_on_warn=1` (some hardened configurations) —
   this would **crash** the system

### Classification

This is a **bug fix** — removing a false assertion that incorrectly
triggers a kernel warning on a valid code path. It's not a cleanup or
feature addition.

### Risk Assessment

- **Scope**: One line removal in a single file
- **Risk**: Essentially zero — removing a bogus `ASSERT(false)` cannot
  introduce regressions
- **Benefit**: Prevents spurious WARN_ON_ONCE on valid code paths;
  prevents crashes on panic-on-warn configurations
- **Subsystem**: AMD display driver (DCN 3.2) — widely used on modern
  AMD GPUs

### Stable Criteria Check

1. **Obviously correct and tested**: Yes — removing a known-false assert
   is obviously correct. Reviewed-by and cherry-picked.
2. **Fixes a real bug**: Yes — spurious WARN_ON triggering on a valid
   code path is a real bug.
3. **Important issue**: Moderate — causes kernel warnings and potential
   crashes on panic-on-warn systems.
4. **Small and contained**: Yes — single line removal.
5. **No new features**: Correct — no new functionality added.

**YES**

 drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c
index 30bb5d8d85dc2..c6fde355ac823 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c
@@ -502,7 +502,6 @@ bool dcn32_set_mcm_luts(
 		lut_params = &plane_state->in_shaper_func.pwl;
 	else if (plane_state->in_shaper_func.type == TF_TYPE_DISTRIBUTED_POINTS) {
 		// TODO: dpp_base replace
-		ASSERT(false);
 		cm3_helper_translate_curve_to_hw_format(plane_state->ctx,
 							&plane_state->in_shaper_func,
 							&dpp_base->shaper_params, true);
-- 
2.51.0