From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Breno Baptista <brenomb07@gmail.com>,
Takashi Iwai <tiwai@suse.de>, Sasha Levin <sashal@kernel.org>,
sbinding@opensource.cirrus.com, kailang@realtek.com,
chris.chiu@canonical.com, edip@medip.dev
Subject: [PATCH AUTOSEL 6.18-6.12] ALSA: hda/realtek: Enable headset mic for Acer Nitro 5
Date: Mon, 9 Feb 2026 07:26:42 -0500 [thread overview]
Message-ID: <20260209122714.1037915-3-sashal@kernel.org> (raw)
In-Reply-To: <20260209122714.1037915-1-sashal@kernel.org>
From: Breno Baptista <brenomb07@gmail.com>
[ Upstream commit 51db05283f7c9c95a3e6853a3044cd04226551bf ]
Add quirk to support microphone input through headphone jack on Acer Nitro 5 AN515-57 (ALC295).
Signed-off-by: Breno Baptista <brenomb07@gmail.com>
Link: https://patch.msgid.link/20260205024341.26694-1-brenomb07@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
LLM Generated explanations, may be completely bogus:
## Analysis: ALSA: hda/realtek: Enable headset mic for Acer Nitro 5
### Commit Message Analysis
This commit adds a hardware quirk entry (`SND_PCI_QUIRK`) for the Acer
Nitro 5 AN515-57 laptop to enable headset microphone input through the
headphone jack. The codec is ALC295, and the fixup applied is
`ALC2XX_FIXUP_HEADSET_MIC`.
### Code Change Analysis
The change is a **single line addition** in the `alc269_fixup_tbl[]`
quirk table:
```c
SND_PCI_QUIRK(0x1025, 0x1539, "Acer Nitro 5 AN515-57",
ALC2XX_FIXUP_HEADSET_MIC),
```
- **Vendor ID 0x1025** = Acer
- **Subsystem ID 0x1539** = Acer Nitro 5 AN515-57
- **Fixup: ALC2XX_FIXUP_HEADSET_MIC** = an existing, well-tested fixup
already used by similar Acer Nitro models
The entry is inserted in the correct sorted position (between 0x1534 and
0x159c), and notably, the adjacent entries for Acer Nitro 5 AN515-58
(0x159c) and AN517-55 (0x1597) already use the exact same
`ALC2XX_FIXUP_HEADSET_MIC` fixup. This is simply extending an existing
working quirk to another model in the same product family.
### Classification
This is a **hardware quirk addition** — one of the explicitly allowed
exception categories for stable backports. It:
1. Fixes a real user-facing problem: the headset microphone doesn't work
without this quirk on the Acer Nitro 5 AN515-57
2. Uses an existing, proven fixup mechanism (`ALC2XX_FIXUP_HEADSET_MIC`)
3. Only affects the specific hardware identified by the PCI subsystem ID
4. Has zero risk of regression for any other hardware
### Scope and Risk Assessment
- **Lines changed**: 1 (addition only)
- **Files changed**: 1
- **Risk**: Essentially zero — the quirk is matched by PCI
vendor/subsystem ID and only applies to the specific Acer laptop model
- **Subsystem maturity**: The HDA Realtek quirk table is one of the most
stable and well-understood mechanisms in the kernel; hundreds of
similar entries exist
### User Impact
Without this quirk, users of the Acer Nitro 5 AN515-57 cannot use the
headset microphone through the headphone jack. This is a common laptop
(gaming line) and headset mic support is essential for many users
(calls, gaming, etc.). The commit was submitted by an end user (Breno
Baptista) who presumably experienced the problem.
### Stability Indicators
- Accepted by Takashi Iwai (ALSA maintainer)
- Follows the exact same pattern as dozens of other quirk entries in the
same table
- The same fixup (`ALC2XX_FIXUP_HEADSET_MIC`) is already proven on
sibling models (AN515-58, AN517-55)
### Dependencies
None. This is a self-contained single-line quirk table entry addition.
The `ALC2XX_FIXUP_HEADSET_MIC` fixup and the quirk infrastructure
already exist in all stable trees that support this driver.
### Conclusion
This is a textbook example of a hardware quirk addition that belongs in
stable trees. It's a single-line addition to an existing quirk table,
using an already-proven fixup, fixing a real hardware issue (non-
functional headset mic) on a specific laptop model, with zero risk to
any other hardware or code path.
**YES**
sound/hda/codecs/realtek/alc269.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 9097de7d2e3d7..7604851d53b2f 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6238,6 +6238,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1025, 0x1430, "Acer TravelMate B311R-31", ALC256_FIXUP_ACER_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1025, 0x1466, "Acer Aspire A515-56", ALC255_FIXUP_ACER_HEADPHONE_AND_MIC),
SND_PCI_QUIRK(0x1025, 0x1534, "Acer Predator PH315-54", ALC255_FIXUP_ACER_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1025, 0x1539, "Acer Nitro 5 AN515-57", ALC2XX_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x1025, 0x159c, "Acer Nitro 5 AN515-58", ALC2XX_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x1025, 0x169a, "Acer Swift SFG16", ALC256_FIXUP_ACER_SFG16_MICMUTE_LED),
SND_PCI_QUIRK(0x1025, 0x1826, "Acer Helios ZPC", ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2),
--
2.51.0
next prev parent reply other threads:[~2026-02-09 12:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 12:26 [PATCH AUTOSEL 6.18-6.12] drm/amd/display: extend delta clamping logic to CM3 LUT helper Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18] io_uring/fdinfo: be a bit nicer when looping a lot of SQEs/CQEs Sasha Levin
2026-02-09 12:26 ` Sasha Levin [this message]
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-5.10] platform/x86: classmate-laptop: Add missing NULL pointer checks Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.6] platform/x86/amd/pmc: Add quirk for MECHREVO Wujie 15X Pro Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.6] ASoC: amd: yc: Add quirk for HP 200 G2a 16 Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-5.15] platform/x86: panasonic-laptop: Fix sysfs group leak in error path Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-5.15] ASoC: fsl_xcvr: fix missing lock in fsl_xcvr_mode_put() Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.12] tracing/dma: Cap dma_map_sg tracepoint arrays to prevent buffer overflow Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-5.10] drm/tegra: hdmi: sor: Fix error: variable ‘j’ set but not used Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.1] ASoC: Intel: sof_es8336: Add DMI quirk for Huawei BOD-WXX9 Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18] ASoC: sof_sdw: Add a quirk for Lenovo laptop using sidecar amps with cs42l43 Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-5.10] gpiolib: acpi: Fix gpio count with string references Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.6] ASoC: cs42l43: Correct handling of 3-pole jack load detection Sasha Levin
2026-02-09 12:26 ` [PATCH AUTOSEL 6.18-6.12] drm/amd/display: remove assert around dpp_base replacement Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260209122714.1037915-3-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=brenomb07@gmail.com \
--cc=chris.chiu@canonical.com \
--cc=edip@medip.dev \
--cc=kailang@realtek.com \
--cc=patches@lists.linux.dev \
--cc=sbinding@opensource.cirrus.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox