From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88A6A383C86 for ; Sat, 28 Feb 2026 18:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302172; cv=none; b=n/0ay5YJbBdbP2dyPlxsvxD+uxDB6bnB+SYrdUhJM+N3HCnanlXWAIdcg+NmEV53w7fcrr14XrQ8l9ZGChD0atXUUZj1wyJonruLQiTa5AKzcO0OZ0yO+9yLB8Y6ZJUJxhCqZSRDYzXSBVwNp4Y1CYV8AZFe81whKVVyxpckv6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302172; c=relaxed/simple; bh=zClUpQWpURzbmsf+sToB4LrC6EXA7IQqRm8XwYH/xLs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QfKUOaKb5OdYL13e146XZyC4eS1MDkmYgYgfRBebGTwGrKjThbZTKRTZA95wofh5n8bvllGiSiE9DC7RAD5f2f35Ch3FnazIi14eB0jxbDQ5fmNR9QfVB4wcuwEnn3R0T+0u7Kzok91zjPDcLlh8UmzKp9AwncR9+AZmYel8cEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=esit8W3P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="esit8W3P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7AB9C19423; Sat, 28 Feb 2026 18:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772302172; bh=zClUpQWpURzbmsf+sToB4LrC6EXA7IQqRm8XwYH/xLs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=esit8W3PEOSsvn9LjS8It5ll/c+rkSREl7KGRDS8TPHn1ciLThkrN8IX7D+H6DVsv BzNO+5TTo0h57AmYyqw9tsyV97fWyNsj3iRuGyx87hD15JzHbZJKwMqJ+tHTn2ISUS zyOhE+rNVWbqKi4S7vNRMCBWEIr/ov7o9/BeqUKpHIBxoJ9G7ehxJI1sUqRvovGKlR 2bLCIMKiXS1/f9teIA9nyOVgqmP1dgxqAPr3i0vIiaZZqQ4T55u2FZO1rHqyAbaXSi ZedM6lAZS+cDFmHyTE3VBmIRGRwx91F+uKlFPob6pFeITNw8dicrOk3+uu6keoQ4mF nGcc2AXUrx5Hw== From: Sasha Levin To: patches@lists.linux.dev Cc: Waqar Hameed , Linus Walleij , Sebastian Reichel , Sasha Levin Subject: [PATCH 6.6 170/283] power: supply: ab8500: Fix use-after-free in power_supply_changed() Date: Sat, 28 Feb 2026 13:05:12 -0500 Message-ID: <20260228180709.1583486-170-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228180709.1583486-1-sashal@kernel.org> References: <20260228180709.1583486-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Waqar Hameed [ Upstream commit c4af8a98bb52825a5331ae1d0604c0ea6956ba4b ] Using the `devm_` variant for requesting IRQ _before_ the `devm_` variant for allocating/registering the `power_supply` handle, means that the `power_supply` handle will be deallocated/unregistered _before_ the interrupt handler (since `devm_` naturally deallocates in reverse allocation order). This means that during removal, there is a race condition where an interrupt can fire just _after_ the `power_supply` handle has been freed, *but* just _before_ the corresponding unregistration of the IRQ handler has run. This will lead to the IRQ handler calling `power_supply_changed()` with a freed `power_supply` handle. Which usually crashes the system or otherwise silently corrupts the memory... Note that there is a similar situation which can also happen during `probe()`; the possibility of an interrupt firing _before_ registering the `power_supply` handle. This would then lead to the nasty situation of using the `power_supply` handle *uninitialized* in `power_supply_changed()`. Commit 1c1f13a006ed ("power: supply: ab8500: Move to componentized binding") introduced this issue during a refactorization. Fix this racy use-after-free by making sure the IRQ is requested _after_ the registration of the `power_supply` handle. Fixes: 1c1f13a006ed ("power: supply: ab8500: Move to componentized binding") Signed-off-by: Waqar Hameed Reviewed-by: Linus Walleij Link: https://patch.msgid.link/ccf83a09942cb8dda3dff70b2682f2c2e9cb97f2.1766268280.git.waqar.hameed@axis.com Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/ab8500_charger.c | 40 +++++++++++++-------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c index 308e68545d44d..c6d513953b042 100644 --- a/drivers/power/supply/ab8500_charger.c +++ b/drivers/power/supply/ab8500_charger.c @@ -3456,26 +3456,6 @@ static int ab8500_charger_probe(struct platform_device *pdev) return ret; } - /* Request interrupts */ - for (i = 0; i < ARRAY_SIZE(ab8500_charger_irq); i++) { - irq = platform_get_irq_byname(pdev, ab8500_charger_irq[i].name); - if (irq < 0) - return irq; - - ret = devm_request_threaded_irq(dev, - irq, NULL, ab8500_charger_irq[i].isr, - IRQF_SHARED | IRQF_NO_SUSPEND | IRQF_ONESHOT, - ab8500_charger_irq[i].name, di); - - if (ret != 0) { - dev_err(dev, "failed to request %s IRQ %d: %d\n" - , ab8500_charger_irq[i].name, irq, ret); - return ret; - } - dev_dbg(dev, "Requested %s IRQ %d: %d\n", - ab8500_charger_irq[i].name, irq, ret); - } - /* initialize lock */ spin_lock_init(&di->usb_state.usb_lock); mutex_init(&di->usb_ipt_crnt_lock); @@ -3604,6 +3584,26 @@ static int ab8500_charger_probe(struct platform_device *pdev) return PTR_ERR(di->usb_chg.psy); } + /* Request interrupts */ + for (i = 0; i < ARRAY_SIZE(ab8500_charger_irq); i++) { + irq = platform_get_irq_byname(pdev, ab8500_charger_irq[i].name); + if (irq < 0) + return irq; + + ret = devm_request_threaded_irq(dev, + irq, NULL, ab8500_charger_irq[i].isr, + IRQF_SHARED | IRQF_NO_SUSPEND | IRQF_ONESHOT, + ab8500_charger_irq[i].name, di); + + if (ret != 0) { + dev_err(dev, "failed to request %s IRQ %d: %d\n" + , ab8500_charger_irq[i].name, irq, ret); + return ret; + } + dev_dbg(dev, "Requested %s IRQ %d: %d\n", + ab8500_charger_irq[i].name, irq, ret); + } + /* * Check what battery we have, since we always have the USB * psy, use that as a handle. -- 2.51.0