From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1098D2737F2 for ; Sat, 28 Feb 2026 18:09:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302182; cv=none; b=NOmUynbk1aw8v1SPjStbilGAG6kslbUr5uWvETiHY08PO/pmbi2BfbD+a4ybMm8mZ6b27Qd0B3t9SZh+ALPtizI18kiewMUqA45TuGrrCZky4zumqKFm5XZm/uFt99dNhrXaEMKw72R5oWcOuR/Q8Pi8HNS+cskpAMEtQ7n/LBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302182; c=relaxed/simple; bh=6CeozlbN+YPI1gA9B/K4u6Rm1RgKcEWzPrFCIM5P9Ss=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m5ld0nzgEscyPF0tUPagTm8o7CnJBJ5JXEArA+rqux3UI4dEwXHRPmSRObXbaC3YQvwZiuVGbOrc2ZcxijP6knDGoBYBaxgOo6irskuQx7GchkdvWLZZOfugxyBH5lQT22iRvtyaqo75+bpHg7yJ5wO0V9gSEkVmsgulRknmdT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZPQUIZR9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZPQUIZR9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E2B1C116D0; Sat, 28 Feb 2026 18:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772302182; bh=6CeozlbN+YPI1gA9B/K4u6Rm1RgKcEWzPrFCIM5P9Ss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZPQUIZR9Yg1kHMm35InukHYByUtTHihFEXOTRiXAXaUDUp0fIL4JTzP0TGBNsS+Z0 j8H8Ni8RMW+B22TvnADdGG5nBBcNN2vfnguqw6cd2CQeap+xr55L89UjMmFh9OFgFv ozTENhnNOm5IO87AM7Ao3xocK8QNxIPPB6TWGfI34qBQiCH+IaYDfFEWep6Wj9MRy8 lj4QHmmbBqYpt4s2IkkSGjCeFM1ySjRJJQiCjimyYvYQkIAnnmoavAz9q5s7WdRYBE Z2D2wr4oCKuetlAKByh8viYEylvQhm3R7/4Geuxck7mRpsdnuHiZ0GHb+ySj1JcP8k lv8+N4BKk0Pzg== From: Sasha Levin To: patches@lists.linux.dev Cc: Jiasheng Jiang , Zhu Yanjun , Leon Romanovsky , Sasha Levin Subject: [PATCH 6.6 182/283] RDMA/rxe: Fix double free in rxe_srq_from_init Date: Sat, 28 Feb 2026 13:05:24 -0500 Message-ID: <20260228180709.1583486-182-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228180709.1583486-1-sashal@kernel.org> References: <20260228180709.1583486-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Jiasheng Jiang [ Upstream commit 0beefd0e15d962f497aad750b2d5e9c3570b66d1 ] In rxe_srq_from_init(), the queue pointer 'q' is assigned to 'srq->rq.queue' before copying the SRQ number to user space. If copy_to_user() fails, the function calls rxe_queue_cleanup() to free the queue, but leaves the now-invalid pointer in 'srq->rq.queue'. The caller of rxe_srq_from_init() (rxe_create_srq) eventually calls rxe_srq_cleanup() upon receiving the error, which triggers a second rxe_queue_cleanup() on the same memory, leading to a double free. The call trace looks like this: kmem_cache_free+0x.../0x... rxe_queue_cleanup+0x1a/0x30 [rdma_rxe] rxe_srq_cleanup+0x42/0x60 [rdma_rxe] rxe_elem_release+0x31/0x70 [rdma_rxe] rxe_create_srq+0x12b/0x1a0 [rdma_rxe] ib_create_srq_user+0x9a/0x150 [ib_core] Fix this by moving 'srq->rq.queue = q' after copy_to_user. Fixes: aae0484e15f0 ("IB/rxe: avoid srq memory leak") Signed-off-by: Jiasheng Jiang Link: https://patch.msgid.link/20260112015412.29458-1-jiashengjiangcool@gmail.com Reviewed-by: Zhu Yanjun Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/sw/rxe/rxe_srq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/sw/rxe/rxe_srq.c b/drivers/infiniband/sw/rxe/rxe_srq.c index 2a234f26ac104..c9a7cd38953d3 100644 --- a/drivers/infiniband/sw/rxe/rxe_srq.c +++ b/drivers/infiniband/sw/rxe/rxe_srq.c @@ -77,9 +77,6 @@ int rxe_srq_from_init(struct rxe_dev *rxe, struct rxe_srq *srq, goto err_free; } - srq->rq.queue = q; - init->attr.max_wr = srq->rq.max_wr; - if (uresp) { if (copy_to_user(&uresp->srq_num, &srq->srq_num, sizeof(uresp->srq_num))) { @@ -88,6 +85,9 @@ int rxe_srq_from_init(struct rxe_dev *rxe, struct rxe_srq *srq, } } + srq->rq.queue = q; + init->attr.max_wr = srq->rq.max_wr; + return 0; err_free: -- 2.51.0