From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC1F1359A63 for ; Sat, 28 Feb 2026 18:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302407; cv=none; b=KFzZk4X/YR8DQgg1kjzqT74azlgzRe4wn6crYpAbeWh9XvuVE/XFORItACUnn2vpb/pZYDxymgZHIOMeoya7CmdyqkDq4aXJykaIbQnBB3dciNHXQQoD6m68kA1N8nOhcCbXR6Ss4BN+OxdXPXYYItgpewkARlS5E274TOW8VyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302407; c=relaxed/simple; bh=8ylMSu9RkVLkCu90kn/jM2qA6E673F/XLDrumUkahPI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nIOueeGZMe9DIekRufxTAkm/w73UE18aOV4nLiE7KKxUnuKnq/YXtgiVSu6UJ/sAz5k1shhGF9GH5JIEVMZ+PsYojw4PJ+UhPckdpoWsPl45Q9L8YF0Jg11eGsFU+6jafBz8pZ6Bk/0qR8hpiUtyWmuANQmCasukPbHFladdKvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U2SP9FGW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U2SP9FGW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45DE5C19423; Sat, 28 Feb 2026 18:13:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772302407; bh=8ylMSu9RkVLkCu90kn/jM2qA6E673F/XLDrumUkahPI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U2SP9FGWpoaGDNsVggLqJxLkUdN5wrjs9NkL2iDBDq/8Vgv13a4cgOSxOic0OQQIh DKUqdyNUWxk7Wr1aQZzvxjD2mN9cmSiaZiYyT4JkqxVP+22lmFctDxl4tuZPuudrBJ sdGe4gYAvWeDZZDKtvqwKs1v7p2XW4DxLC8DuUNvyrgDJbWWYDb/8f85kptoFuFySr m2IdEdLE/+X3CL4ch+68UCZ/pJr/e2lxm1fzQgOcUCoyCX4SjBWjxhKCYukBMkpoN6 iN9CnviPGCTkTj2NgsCZjaA9vzwkMQYgClolQ2uvrCmg+AUfsk6G/WKhicfnyV2VQN U0Ry9JaZQ5xbg== From: Sasha Levin To: patches@lists.linux.dev Cc: Waqar Hameed , Sebastian Reichel , Sasha Levin Subject: [PATCH 6.1 140/232] power: supply: rt9455: Fix use-after-free in power_supply_changed() Date: Sat, 28 Feb 2026 13:09:53 -0500 Message-ID: <20260228181127.1592657-140-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228181127.1592657-1-sashal@kernel.org> References: <20260228181127.1592657-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Waqar Hameed [ Upstream commit e2febe375e5ea5afed92f4cd9711bde8f24ee6d2 ] Using the `devm_` variant for requesting IRQ _before_ the `devm_` variant for allocating/registering the `power_supply` handle, means that the `power_supply` handle will be deallocated/unregistered _before_ the interrupt handler (since `devm_` naturally deallocates in reverse allocation order). This means that during removal, there is a race condition where an interrupt can fire just _after_ the `power_supply` handle has been freed, *but* just _before_ the corresponding unregistration of the IRQ handler has run. This will lead to the IRQ handler calling `power_supply_changed()` with a freed `power_supply` handle. Which usually crashes the system or otherwise silently corrupts the memory... Note that there is a similar situation which can also happen during `probe()`; the possibility of an interrupt firing _before_ registering the `power_supply` handle. This would then lead to the nasty situation of using the `power_supply` handle *uninitialized* in `power_supply_changed()`. Fix this racy use-after-free by making sure the IRQ is requested _after_ the registration of the `power_supply` handle. Fixes: e86d69dd786e ("power_supply: Add support for Richtek RT9455 battery charger") Signed-off-by: Waqar Hameed Link: https://patch.msgid.link/1567d831e04c3e2fcb9e18dd36b7bcba4634581a.1766268280.git.waqar.hameed@axis.com Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/rt9455_charger.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/power/supply/rt9455_charger.c b/drivers/power/supply/rt9455_charger.c index c5597967a0699..566243a423c8f 100644 --- a/drivers/power/supply/rt9455_charger.c +++ b/drivers/power/supply/rt9455_charger.c @@ -1665,6 +1665,15 @@ static int rt9455_probe(struct i2c_client *client, rt9455_charger_config.supplied_to = rt9455_charger_supplied_to; rt9455_charger_config.num_supplicants = ARRAY_SIZE(rt9455_charger_supplied_to); + + info->charger = devm_power_supply_register(dev, &rt9455_charger_desc, + &rt9455_charger_config); + if (IS_ERR(info->charger)) { + dev_err(dev, "Failed to register charger\n"); + ret = PTR_ERR(info->charger); + goto put_usb_notifier; + } + ret = devm_request_threaded_irq(dev, client->irq, NULL, rt9455_irq_handler_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT, @@ -1680,14 +1689,6 @@ static int rt9455_probe(struct i2c_client *client, goto put_usb_notifier; } - info->charger = devm_power_supply_register(dev, &rt9455_charger_desc, - &rt9455_charger_config); - if (IS_ERR(info->charger)) { - dev_err(dev, "Failed to register charger\n"); - ret = PTR_ERR(info->charger); - goto put_usb_notifier; - } - return 0; put_usb_notifier: -- 2.51.0