From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D1C136C9EE for ; Sat, 28 Feb 2026 18:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302326; cv=none; b=kv6ytM730TUI17GNT8iIVl5Tsmto3vZUIDZSHfHIlu7UMC1/g0+MAM103fDg6nth7tQ2KQMN6vIfQb5j8pybgLx8X4aKgYPf67jv1sZnPzoTIkUNSWZpFpLadRNpQ0HuO55Y64NlQ4VxmbdYga1MMZ/7bJhGrO5WW9br94pjjek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302326; c=relaxed/simple; bh=vm+8aRIihVf0o47fLvGksbZqIPSzwGfvOoxQVSJHEbc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C22k2za0bxtNdkfUI6JezOhsmuCIUqLiObjo65t5pOh8oEx7U8dvWqOn6hEmqJSD1y8u7U5qRTP+JEKGCrJYX6gkvS6DG9PU7Avu4XDPr5p/TS4Yz9koYyVsQ2xBeDwQX+pf0X6HEcCONTaujwyQ5gCP167MLNWrtO7e//dxLb0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=smHC1Mdu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="smHC1Mdu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0510DC116D0; Sat, 28 Feb 2026 18:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772302326; bh=vm+8aRIihVf0o47fLvGksbZqIPSzwGfvOoxQVSJHEbc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=smHC1Mdu01xoQHusgPnD1ZKcN1FDxpOIFrcdrOZL5UkfY3dc4VZ07xfI1uy0W6hxa D69drVH30jYgU5RodebcZRnplddJ80aYLIFh5xHOu6aQ+5R/NH51/58IYDOFM3JXLs UdoIeMXsKM4VoYmy6r9HbPQAYyUAeQ1Heko1g90KJLYHz0QU27qVxzzLEvEi+tttq2 8LOvCZZD7qj3P7VIADECfa1T6D1wSIvoTwTH83gYGdN6Y+85EAQDaVHUe6KWDYixEK YpPITSCn1VMYv+W23YoKEXCfVLLElOYwR+QT9I84UAerYySFxlQf/D9rBFjIyW68sE uA4oRP09X7wfw== From: Sasha Levin To: patches@lists.linux.dev Cc: Sebastian Andrzej Siewior , Thomas Gleixner , Sasha Levin Subject: [PATCH 6.1 046/232] EDAC/altera: Remove IRQF_ONESHOT Date: Sat, 28 Feb 2026 13:08:19 -0500 Message-ID: <20260228181127.1592657-46-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228181127.1592657-1-sashal@kernel.org> References: <20260228181127.1592657-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Sebastian Andrzej Siewior [ Upstream commit 5c858d6c66304b4c7579582ec5235f02d43578ea ] Passing IRQF_ONESHOT ensures that the interrupt source is masked until the secondary (threaded) handler is done. If only a primary handler is used then the flag makes no sense because the interrupt can not fire (again) while its handler is running. The flag also prevents force-threading of the primary handler and the irq-core will warn about this. Remove IRQF_ONESHOT from irqflags. Fixes: a29d64a45eed1 ("EDAC, altera: Add IRQ Flags to disable IRQ while handling") Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Link: https://patch.msgid.link/20260128095540.863589-11-bigeasy@linutronix.de Signed-off-by: Sasha Levin --- drivers/edac/altera_edac.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index 368ede6a4f596..09b6871151676 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -1573,8 +1573,7 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) goto err_release_group_1; } rc = devm_request_irq(&altdev->ddev, altdev->sb_irq, - prv->ecc_irq_handler, - IRQF_ONESHOT | IRQF_TRIGGER_HIGH, + prv->ecc_irq_handler, IRQF_TRIGGER_HIGH, ecc_name, altdev); if (rc) { edac_printk(KERN_ERR, EDAC_DEVICE, "PortB SBERR IRQ error\n"); @@ -1597,8 +1596,7 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) goto err_release_group_1; } rc = devm_request_irq(&altdev->ddev, altdev->db_irq, - prv->ecc_irq_handler, - IRQF_ONESHOT | IRQF_TRIGGER_HIGH, + prv->ecc_irq_handler, IRQF_TRIGGER_HIGH, ecc_name, altdev); if (rc) { edac_printk(KERN_ERR, EDAC_DEVICE, "PortB DBERR IRQ error\n"); @@ -1981,8 +1979,7 @@ static int altr_edac_a10_device_add(struct altr_arria10_edac *edac, goto err_release_group1; } rc = devm_request_irq(edac->dev, altdev->sb_irq, prv->ecc_irq_handler, - IRQF_ONESHOT | IRQF_TRIGGER_HIGH, - ecc_name, altdev); + IRQF_TRIGGER_HIGH, ecc_name, altdev); if (rc) { edac_printk(KERN_ERR, EDAC_DEVICE, "No SBERR IRQ resource\n"); goto err_release_group1; @@ -2004,7 +2001,7 @@ static int altr_edac_a10_device_add(struct altr_arria10_edac *edac, goto err_release_group1; } rc = devm_request_irq(edac->dev, altdev->db_irq, prv->ecc_irq_handler, - IRQF_ONESHOT | IRQF_TRIGGER_HIGH, + IRQF_TRIGGER_HIGH, ecc_name, altdev); if (rc) { edac_printk(KERN_ERR, EDAC_DEVICE, "No DBERR IRQ resource\n"); -- 2.51.0