Re: [PATCH 6.1 057/232] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on

David Heidelberg
2026-02-28T18:13:37Z

Just as addition to the 6.12 explanation, currently 6.6 or any older
isn't supported by any distribution supporting this phone, so it's
slightly irrelevant here, but same rules as for 6.12 should apply here,
thus please do not apply this patch. See message bellow

=== 6.12 mail

I believe this patch SHOULDN'T be backported. The 6.12 trees for sdm845
following stable releases may have drivers and setup, which may not be
able to work with regulators properly. This got fixed later with fixes
to sofef00 and introduction of s6e3fc2x01 driver with proper regulator
handling.

The clean (without additional patches) 6.12 stable won't work anyway
here, so it would be meaningless add this patch.

Thanks
David

On 28/02/2026 19:08, Sasha Levin wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
>
> [ Upstream commit 45d1f42d3e84b5880cf9fab1eb24a7818320eeb7 ]
>
> The panel regulator doesn't need to be always on, so remove this
> property.
>
> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Link: https://lore.kernel.org/r/20251118-dts-oneplus-regulators-v2-2-3e67cea1e4e7@ixit.cz
> Signed-off-by: Bjorn Andersson <andersson@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> index 281e1178a2f46..ac3db3d5d2bad 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> @@ -230,7 +230,6 @@ vreg_l14a_1p88: ldo14 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> - regulator-always-on;
> };
>
> vreg_l17a_1p3: ldo17 {

--
David Heidelberg