From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8980A38F650 for ; Sat, 28 Feb 2026 18:15:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302507; cv=none; b=WHbJ8thsi4ct14uoneBuZvXb86UgqCGxGifsFBAOcmDpcvLO5xFBNsiWsG5fYVroaNRVUWal8FSGgEH12S3HRnk/Kq3BAjhXmXA8rM+pxVTnB82MrhEm8DAFv8qz38ktgNk0Jcpt3UKo+EjFkQOq76diOFPOYkwFFNDW9WxI8Z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302507; c=relaxed/simple; bh=ZcLtMZ55CvCApql4v/W1gA/dd+Jadmfq3JsCZ/RypjQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jUYnrCD8AwDNdoA0Ib+XBiCqmNPzf9LPFOcSJGsnP4gGQEfbeR/C4nRnL2O92XJndEkgY5o/mmCNFsHqBoIKk5zE7TP9aIruprXymFFT/amr2SZGL70g18BR8bCLQdE1X7XGGmj6sNsXeg4tMWP0lyQTnqdBz8f2P5DckKQ/GrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cknQcCJC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cknQcCJC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77DF9C116D0; Sat, 28 Feb 2026 18:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772302507; bh=ZcLtMZ55CvCApql4v/W1gA/dd+Jadmfq3JsCZ/RypjQ=; h=From:To:Cc:Subject:Date:From; b=cknQcCJC0bf6+a0lJap/RsKdKiidbdvkNb6DODf0EI4sqt0LOT4Rv/Wzos56XWuqe YisGNjReSd7vAwnZ2SMtYbrL95flnE2VJI5kWfxQVwOo6goQWIYf2na2kkH/gpr+9t f/8AZFe1Vn/AFomfe4T9vBBS1lsvCaPd1ZgUsCkqfLLPD7Bc+oWSWTzqLTeV0+6rl8 xHUpDUYhWLUH7yDyQ0PGUruJMtbKTYXuDZhxZuFKePjsBAmWXXrDD15ZMOFKn0RM7v G2VI4J3YRfRsCHbwxgYroU5npydL4IgYYPxZpjvhfGQ0gbfcqV6AJTVjZVGhKoLZ7S X9oHg78jXbxiw== From: Sasha Levin To: patches@lists.linux.dev Cc: YunJe Shin , YunJe Shin , Bernard Metzler , Leon Romanovsky , Greg Kroah-Hartman Subject: [PATCH 5.15 001/164] RDMA/siw: Fix potential NULL pointer dereference in header processing Date: Sat, 28 Feb 2026 13:12:20 -0500 Message-ID: <20260228181505.1600663-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: YunJe Shin commit 14ab3da122bd18920ad57428f6cf4fade8385142 upstream. If siw_get_hdr() returns -EINVAL before set_rx_fpdu_context(), qp->rx_fpdu can be NULL. The error path in siw_tcp_rx_data() dereferences qp->rx_fpdu->more_ddp_segs without checking, which may lead to a NULL pointer deref. Only check more_ddp_segs when rx_fpdu is present. KASAN splat: [ 101.384271] KASAN: null-ptr-deref in range [0x00000000000000c0-0x00000000000000c7] [ 101.385869] RIP: 0010:siw_tcp_rx_data+0x13ad/0x1e50 Fixes: 8b6a361b8c48 ("rdma/siw: receive path") Signed-off-by: YunJe Shin Link: https://patch.msgid.link/20260204092546.489842-1-ioerts@kookmin.ac.kr Acked-by: Bernard Metzler Signed-off-by: Leon Romanovsky Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/sw/siw/siw_qp_rx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/sw/siw/siw_qp_rx.c b/drivers/infiniband/sw/siw/siw_qp_rx.c index fd721cc19682e..6b049858644e8 100644 --- a/drivers/infiniband/sw/siw/siw_qp_rx.c +++ b/drivers/infiniband/sw/siw/siw_qp_rx.c @@ -1456,7 +1456,8 @@ int siw_tcp_rx_data(read_descriptor_t *rd_desc, struct sk_buff *skb, } if (unlikely(rv != 0 && rv != -EAGAIN)) { if ((srx->state > SIW_GET_HDR || - qp->rx_fpdu->more_ddp_segs) && run_completion) + (qp->rx_fpdu && qp->rx_fpdu->more_ddp_segs)) && + run_completion) siw_rdmap_complete(qp, rv); siw_dbg_qp(qp, "rx error %d, rx state %d\n", rv, -- 2.51.0