From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E72B35AC02 for ; Sat, 28 Feb 2026 18:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302678; cv=none; b=LoC7y70sqMX4sAvPCTgmmpH39Z7tafFE7OKaMS7ekpz/uXbJh44OfWcKBXfrUvIVn5HEfHn83gBkZOHnT3JMnUI3j/e6LjZgNfXYkzWtIARXbggyQLU3YOAAJFLZZAohxPbqS/3m69fGI3ni9VuPV9TqHnzYDTEqSvm29oZGJ2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302678; c=relaxed/simple; bh=dRLhpepTXNwFk1pQVeRp1JsaIP6PeI4quhvOVy3MNU0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DBEs6txHyrdu4yXCjr/o5NRrEYScpG4FIWfecvrxB14EtW2whgc3oMzzdeqnClxK4FDV7ehfcYUgG6yGt8Okn8yrSRCmIeZKaNZjiab3aJ16vJBZHDDW5iSvrEr46fN1SvHnhrwiVRhvFO0yrCmHo+iu4DU84EfSdByYqREV/c8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=igOn4hsf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="igOn4hsf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D724C19425; Sat, 28 Feb 2026 18:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772302678; bh=dRLhpepTXNwFk1pQVeRp1JsaIP6PeI4quhvOVy3MNU0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=igOn4hsfXXxXoswoF1CdssrOyR87H99ClGEVWNHAPkXjutPyGyqt48959nKd6HQdm fJ7y0b6bqvw8pYD5WF/HflbTOEYt0w1k4M9rwDgSgR8lZKVuE32RKNpGMPuPrlOcuu o0PvbesuJtAVZDNYSjN90jAXAPGnsDvvVlUaQlOXgRtswLppjMJQIcD/zuT9P5XjZb phhpyW4CCQdh4TRx8jq9kWkvh7/ehcz0YxXgge0Wu9X/9UxwYiVx1HzDKrr7I1C9hz 9ysf//UWgsYMolIjT6fpoWFt/NfPnV0Rd0pqCfrvAzDtB/57yMWM/LfIXvLEE0wsUS vvNS39Ug2/Eug== From: Sasha Levin To: patches@lists.linux.dev Cc: Sebastian Andrzej Siewior , Thomas Gleixner , Charles Keepax , Andy Shevchenko , Sasha Levin Subject: [PATCH 5.10 028/147] mfd: wm8350-core: Use IRQF_ONESHOT Date: Sat, 28 Feb 2026 13:15:36 -0500 Message-ID: <20260228181736.1605592-28-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228181736.1605592-1-sashal@kernel.org> References: <20260228181736.1605592-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Sebastian Andrzej Siewior [ Upstream commit 553b4999cbe231b5011cb8db05a3092dec168aca ] Using a threaded interrupt without a dedicated primary handler mandates the IRQF_ONESHOT flag to mask the interrupt source while the threaded handler is active. Otherwise the interrupt can fire again before the threaded handler had a chance to run. Mark explained that this should not happen with this hardware since it is a slow irqchip which is behind an I2C/ SPI bus but the IRQ-core will refuse to accept such a handler. Set IRQF_ONESHOT so the interrupt source is masked until the secondary handler is done. Fixes: 1c6c69525b40e ("genirq: Reject bogus threaded irq requests") Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Reviewed-by: Charles Keepax Reviewed-by: Andy Shevchenko Link: https://patch.msgid.link/20260128095540.863589-16-bigeasy@linutronix.de Signed-off-by: Sasha Levin --- include/linux/mfd/wm8350/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mfd/wm8350/core.h b/include/linux/mfd/wm8350/core.h index a3241e4d75486..4816d4f472101 100644 --- a/include/linux/mfd/wm8350/core.h +++ b/include/linux/mfd/wm8350/core.h @@ -663,7 +663,7 @@ static inline int wm8350_register_irq(struct wm8350 *wm8350, int irq, return -ENODEV; return request_threaded_irq(irq + wm8350->irq_base, NULL, - handler, flags, name, data); + handler, flags | IRQF_ONESHOT, name, data); } static inline void wm8350_free_irq(struct wm8350 *wm8350, int irq, void *data) -- 2.51.0