From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADDE535AC0F for ; Sat, 28 Feb 2026 18:18:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302717; cv=none; b=YZnFvNDfaV3JWKnvbXFnsJAknBLz1ERpUdLW4jkc/YvOR/GO7RCZlnNjTago3cCOE6vPlcg2CXye8EWzHuDWtgVnmSH1dvZDROaD4cSmHqFp99TiXdv/Sw8i6rN8oLzXpRjCCpHUbtAMToXLRktCgP17EXxEir4IsLAjESQImoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302717; c=relaxed/simple; bh=kOhDHXsztiXohiCXCBElHawiPymNhbrV1ezRuWcNvUA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OxNQ/BjaBx80g5aW20g0aFDHl55NsmSrVbiH+zUt4iNKBkEh5pebstbl71smsWmq0QImexAYQ1W6uDcFfGaF9Pde6I4r+xeoI52P1w4wnMG+vt80niW+e+TuR94F7ECFcjrAxmfeTxylMngcjJzAzBPWAmB2/rFvOJg3HGxNU9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GnxVm9sI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GnxVm9sI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 374C9C116D0; Sat, 28 Feb 2026 18:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772302717; bh=kOhDHXsztiXohiCXCBElHawiPymNhbrV1ezRuWcNvUA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GnxVm9sIIFBsS/jfWN34nt5R86/AS/9Gc0DVeb3bpE3AxUrJ7zuE0wgxMKuaU6aBy LGCIOG+7pAc0Q6G53NK50LigYLD4fkTw0bW9nmG7ecPLhVDDP3An3AK5TghlybsW6R vSF1u/gIXuv79os/DjQOm9tZA4Cib6JVV7M+0OaV5lK5xCfJQ/fDOmrP/9Xs++hF/e j29F9c0GJyn44oLDQQUYJvOf5nS2cgaJV6h3lEY0IcuyKCkG2Po5VB365l5e9hSLTR 04nHPjqewAperUN5ONqvwAVgwh2SSxbp6nMXm+VfV40uzSSgs2LRINgJFlz/A3KmAy LtUcc/GW/6DmQ== From: Sasha Levin To: patches@lists.linux.dev Cc: Florian Westphal , Sasha Levin Subject: [PATCH 5.10 077/147] netfilter: nft_set_hash: fix get operation on big endian Date: Sat, 28 Feb 2026 13:16:25 -0500 Message-ID: <20260228181736.1605592-77-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228181736.1605592-1-sashal@kernel.org> References: <20260228181736.1605592-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Florian Westphal [ Upstream commit 2f635adbe2642d398a0be3ab245accd2987be0c3 ] tests/shell/testcases/packetpath/set_match_nomatch_hash_fast fails on big endian with: Error: Could not process rule: No such file or directory reset element ip test s { 244.147.90.126 } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Fatal: Cannot fetch element "244.147.90.126" ... because the wrong bucket is searched, jhash() and jhash1_word are not interchangeable on big endian. Fixes: 3b02b0adc242 ("netfilter: nft_set_hash: fix lookups with fixed size hash on big endian") Signed-off-by: Florian Westphal Signed-off-by: Sasha Levin --- net/netfilter/nft_set_hash.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nft_set_hash.c b/net/netfilter/nft_set_hash.c index 8656cb61dd211..3a0d3fd4e42cd 100644 --- a/net/netfilter/nft_set_hash.c +++ b/net/netfilter/nft_set_hash.c @@ -511,15 +511,20 @@ static bool nft_hash_lookup(const struct net *net, const struct nft_set *set, static void *nft_hash_get(const struct net *net, const struct nft_set *set, const struct nft_set_elem *elem, unsigned int flags) { + const u32 *key = (const u32 *)&elem->key.val; struct nft_hash *priv = nft_set_priv(set); u8 genmask = nft_genmask_cur(net); struct nft_hash_elem *he; u32 hash; - hash = jhash(elem->key.val.data, set->klen, priv->seed); + if (set->klen == 4) + hash = jhash_1word(*key, priv->seed); + else + hash = jhash(key, set->klen, priv->seed); + hash = reciprocal_scale(hash, priv->buckets); hlist_for_each_entry_rcu(he, &priv->table[hash], node) { - if (!memcmp(nft_set_ext_key(&he->ext), elem->key.val.data, set->klen) && + if (!memcmp(nft_set_ext_key(&he->ext), key, set->klen) && nft_set_elem_active(&he->ext, genmask)) return he; } -- 2.51.0