From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9602935AC38 for ; Sat, 28 Feb 2026 18:18:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302724; cv=none; b=QNbZdbCULR7jiN0K42SANZ05231b4xkP+d8eGn4795y06+0IG77X4rL/iPipgHBDzalz57y0R5nfdIPEZvMJ7lyAiT2Y+KElEfD93WCJwRJPl8im3DTCDdY2l4wfeZpOkUoiiMxWSNcXX/EYu64ZflAgq4Kt/rOyHfwoCEAaeAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302724; c=relaxed/simple; bh=P6Y3EZuLcz9p7fX/gVufRnU2TIYtbmu8ISbd93mMusU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nx8koLdEaWelfOmPuz+VQKVJHuKv+wIDUeY2RyQkF7m3H6+WZ/3EdaLMdoaGcTVs5EhUPPkBOds8ZLK2oo1zsKRI8zu4p0aEeB8yHzW8YR4w7dT1Gr658MZE/0xf3uJDGS12Jkme1e7VHc+HBeAmTIu/W/IxpldEWGQVJ8fociw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=izda3YV3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="izda3YV3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08B8EC116D0; Sat, 28 Feb 2026 18:18:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772302724; bh=P6Y3EZuLcz9p7fX/gVufRnU2TIYtbmu8ISbd93mMusU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=izda3YV3KEVaeV35aoUPnFy+M0rCehnRYFv/EwwI566F2F6lUw0Q9AQNQzvc6zwx9 bS+LbON31ZJ2HqMv2N+EoUSHK9lqE43ySyZmb4Z6lKyToYySnkl5jKGMdEMxMAqmlo UQYzGKdTRV4fx0+VZHQNzoaIkN2mgSOf9SrlR6mYVuYByxVNn09BHl+9v+5Ac5bhN0 mpjIAjaf4uGgELlvbpIvYAif+ZWLaIAXtArrwho+oq9f15eiUQBQnFNB7Ou9yorGjX rkmBOvI8LkbVtseov5mJoRwaIW3ZroPrrHXd5YkaAt48aUXCp9dGXxwjgoxTvJg7Gt PfbwT+/SlJs7Q== From: Sasha Levin To: patches@lists.linux.dev Cc: Waqar Hameed , Sebastian Reichel , Sasha Levin Subject: [PATCH 5.10 085/147] power: supply: bq25980: Fix use-after-free in power_supply_changed() Date: Sat, 28 Feb 2026 13:16:33 -0500 Message-ID: <20260228181736.1605592-85-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228181736.1605592-1-sashal@kernel.org> References: <20260228181736.1605592-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Waqar Hameed [ Upstream commit 5f0b1cb41906e86b64bf69f5ededb83b0d757c27 ] Using the `devm_` variant for requesting IRQ _before_ the `devm_` variant for allocating/registering the `power_supply` handle, means that the `power_supply` handle will be deallocated/unregistered _before_ the interrupt handler (since `devm_` naturally deallocates in reverse allocation order). This means that during removal, there is a race condition where an interrupt can fire just _after_ the `power_supply` handle has been freed, *but* just _before_ the corresponding unregistration of the IRQ handler has run. This will lead to the IRQ handler calling `power_supply_changed()` with a freed `power_supply` handle. Which usually crashes the system or otherwise silently corrupts the memory... Note that there is a similar situation which can also happen during `probe()`; the possibility of an interrupt firing _before_ registering the `power_supply` handle. This would then lead to the nasty situation of using the `power_supply` handle *uninitialized* in `power_supply_changed()`. Fix this racy use-after-free by making sure the IRQ is requested _after_ the registration of the `power_supply` handle. Fixes: 5069185fc18e ("power: supply: bq25980: Add support for the BQ259xx family") Signed-off-by: Waqar Hameed Link: https://patch.msgid.link/8763035cadb959e14787b3837f2d3db61f6e1c34.1766268280.git.waqar.hameed@axis.com Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/bq25980_charger.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/power/supply/bq25980_charger.c b/drivers/power/supply/bq25980_charger.c index b94ecf814e434..98950e4456c38 100644 --- a/drivers/power/supply/bq25980_charger.c +++ b/drivers/power/supply/bq25980_charger.c @@ -1241,6 +1241,12 @@ static int bq25980_probe(struct i2c_client *client, return ret; } + ret = bq25980_power_supply_init(bq, dev); + if (ret) { + dev_err(dev, "Failed to register power supply\n"); + return ret; + } + if (client->irq) { ret = devm_request_threaded_irq(dev, client->irq, NULL, bq25980_irq_handler_thread, @@ -1251,12 +1257,6 @@ static int bq25980_probe(struct i2c_client *client, return ret; } - ret = bq25980_power_supply_init(bq, dev); - if (ret) { - dev_err(dev, "Failed to register power supply\n"); - return ret; - } - ret = bq25980_hw_init(bq); if (ret) { dev_err(dev, "Cannot initialize the chip.\n"); -- 2.51.0