Re: [PATCH 6.12 044/265] PCI: dw-rockchip: Dont wait for link since we can detect Link Up

Sasha Levin
2026-04-06T15:43:52Z

On Fri, Apr 03, 2026 at 06:47:06PM +0530, Harshit Mogalapalli wrote:
>Hi Greg and Sasha,
>
>
>On 13/03/26 01:37, Greg Kroah-Hartman wrote:
>>6.12-stable review patch. If anyone has any objections, please let me know.
>>
>>------------------
>>
>>From: Niklas Cassel <cassel@kernel.org>
>>
>>[ Upstream commit ec9fd499b9c60a187ac8d6414c3c343c77d32e42 ]
>>
>>The Root Complex specific device tree binding for pcie-dw-rockchip has the
>>'sys' interrupt marked as required.
>>
>>The driver requests the 'sys' IRQ unconditionally, and errors out if not
>>provided.
>>
>>Thus, we can unconditionally set 'use_linkup_irq', so dw_pcie_host_init()
>>doesn't wait for the link to come up.
>>
>>This will skip the wait for link up (since the bus will be enumerated once
>>the link up IRQ is triggered), which reduces the bootup time.
>>
>>Link: https://lore.kernel.org/r/20250113-rockchip-no-wait-v1-1-25417f37b92f@kernel.org
>>Signed-off-by: Niklas Cassel <cassel@kernel.org>
>>[bhelgaas: commit log]
>>Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>>Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
>>Stable-dep-of: fc6298086bfa ("Revert "PCI: dw-rockchip: Don't wait for link since we can detect Link Up"")
>>Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>We need a process improvement here.
>
>We are pulling in a broken commit as a stable-dep, so we can revert it.
>
>Patch 45 is the revert, same logic for pair (46 and 47)
>
>[PATCH 6.12 046/265] PCI: qcom: Dont wait for link if we can detect Link Up
>[PATCH 6.12 047/265] Revert "PCI: qcom: Dont wait for link if we can
>detect Link Up"

This works in our favor: it helps us answer the future question of "why wasn't
this commit backported", and has absolutely no effect on the actual codebase.

What's wrong with this?

--
Thanks,
Sasha