Re: [PATCH 6.12 044/265] PCI: dw-rockchip: Dont wait for link since we can detect Link Up

Harshit Mogalapalli
2026-04-06T15:59:14Z

Hi Sasha,

On 06/04/26 21:13, Sasha Levin wrote:
>>
>> We need a process improvement here.
>>
>> We are pulling in a broken commit as a stable-dep, so we can revert it.
>>
>> Patch 45 is the revert, same logic for pair (46 and 47)
>>
>> [PATCH 6.12 046/265] PCI: qcom: Dont wait for link if we can detect
>> Link Up
>> [PATCH 6.12 047/265] Revert "PCI: qcom: Dont wait for link if we can
>> detect Link Up"
>
> This works in our favor: it helps us answer the future question of "why
> wasn't
> this commit backported", and has absolutely no effect on the actual
> codebase.

I agree this has no effect, but couldn't we just say, the reason we
never backported it because we never have the broken commit(vulnerable
commit) backported ?

>
> What's wrong with this?

Overall, nothing wrong in code, but from a process point of view I felt
this is a bit odd to backport a commit so we can revert it immediately.

Thanks for checking.

Regards,
Harshit