Re: [PATCH 6.12 000/244] 6.12.80-rc1 review

Greg KH
2026-04-02T13:38:13Z

On Thu, Apr 02, 2026 at 03:25:40PM +0200, Miguel Ojeda wrote:
> On Tue, 31 Mar 2026 18:19:10 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 6.12.80 release.
> > There are 244 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 02 Apr 2026 16:16:56 +0000.
> > Anything received after that time might be too late.
>
> Boot-tested under QEMU for Rust x86_64, arm64 and riscv64; built-tested
> for loongarch64:
>
> Tested-by: Miguel Ojeda <ojeda@kernel.org>
>
> There are a bunch of `CLIPPY=1` warnings (errors with `CONFIG_WERROR`)
> like this one on the pin-init change:
>
> warning: unsafe block missing a safety comment
> --> rust/kernel/init/macros.rs:1015:25
> |
> 1015 | unsafe { ::core::pin::Pin::new_unchecked(slot) }
> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> |
> ::: rust/kernel/block/mq/tag_set.rs:27:1
> |
> 27 | #[pin_data(PinnedDrop)]
> | ----------------------- in this procedural macro expansion
> |
> = help: consider adding a safety comment on the preceding line
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks
> = note: requested on the command line with `-W clippy::undocumented-unsafe-blocks`
> = note: this warning originates in the macro `$crate::__pin_data` which comes from the expansion of the attribute macro `pin_data` (in Nightly builds, run with -Z macro-backtrace for more info)
>
> It is not a huge deal, since they are just `CLIPPY=1` warnings, but we
> nevertheless try to keep them clean.
>
> Apart from that, the rest looks OK.
>
> Cc: Benno Lossin <lossin@kernel.org>
> Cc: Gary Guo <gary@garyguo.net>

Ok, I can live with clippy warnings, but will gladly take a fix-up patch
to resolve them :)

thanks,

greg k-h