From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 410BE30ACE6; Mon, 13 Apr 2026 16:15:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776096916; cv=none; b=p7J5hZxNfS5k5om0UGiEq34I3MGlz6QntrKCx69bKZN1ym5xl/otb3VG2nwJ0q/sjLRD1B2WUm2Rhv7+z2c4l/hpnN+1TVYKr3iBwgq11bkgIWcZYno1sOxsn/o0yt1jL+cI39Ee+Gs93fRcducsfxzxIQ1vwZ1ws2QLiy/eJyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776096916; c=relaxed/simple; bh=/b7WRGqVwSeQR4fcmYAeN4djvQt9ZfQDB292qQZ1b10=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MK0CeBY/XcguwP6H6u9IJfwHM3Mah9SiwJ02czmLCGo/+Y4hwhJQTV4negr+vOnzBheeSysYT2dF25AScnPNIGIFBRD8HUFsJnfhh0FOCItb54eS9OKya9hXYw0Nb/pQ4liMYNbjoJOv0wA9P53DGccfXSE64Aeizt22cqQ5wDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XGdmXyfD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XGdmXyfD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC769C2BCAF; Mon, 13 Apr 2026 16:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776096916; bh=/b7WRGqVwSeQR4fcmYAeN4djvQt9ZfQDB292qQZ1b10=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XGdmXyfD6GL9uee8PiTf58mC+tVw4DVGJuXtFH51K/S90gfdzanwvi89/XtMgtMxz Rb9wyj0GnMNcnUSQczi8wqnDjG4TTT58WDhrGZKgss49fvCnw46BxzRHKF41KjyMcS EFlHpNStxD7j+NUzzZc5Y0fQqdiLuHP55ZC59xFY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Carlier , Paolo Abeni Subject: [PATCH 6.6 42/50] net: lan966x: fix page_pool error handling in lan966x_fdma_rx_alloc_page_pool() Date: Mon, 13 Apr 2026 18:01:09 +0200 Message-ID: <20260413155726.082621997@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155724.497323914@linuxfoundation.org> References: <20260413155724.497323914@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Carlier commit 3fd0da4fd8851a7e62d009b7db6c4a05b092bc19 upstream. page_pool_create() can return an ERR_PTR on failure. The return value is used unconditionally in the loop that follows, passing the error pointer through xdp_rxq_info_reg_mem_model() into page_pool_use_xdp_mem(), which dereferences it, causing a kernel oops. Add an IS_ERR check after page_pool_create() to return early on failure. Fixes: 11871aba1974 ("net: lan96x: Use page_pool API") Cc: stable@vger.kernel.org Signed-off-by: David Carlier Link: https://patch.msgid.link/20260405055241.35767-2-devnexen@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c @@ -85,6 +85,8 @@ static int lan966x_fdma_rx_alloc_page_po pp_params.dma_dir = DMA_BIDIRECTIONAL; rx->page_pool = page_pool_create(&pp_params); + if (unlikely(IS_ERR(rx->page_pool))) + return PTR_ERR(rx->page_pool); for (int i = 0; i < lan966x->num_phys_ports; ++i) { struct lan966x_port *port;