From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E810B24E4AF; Mon, 13 Apr 2026 16:04:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776096244; cv=none; b=jKrsjkUB4H6Vf5W9rkJiP7hcUdworsW3pkp9aw/NwXJnthu25j21xjQX9e+NKxmWlfw3flC97I2QKcp6qExVvN57VMz7DmTQJBEn/MUoqZNQtecWda7fsa00fwyCoyuVSyxDuUbdOsoCf6a98DxSpw2pKff4mBMbrwHYzVXRkm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776096244; c=relaxed/simple; bh=u3t8ySsbIJ9VKPPe97ZZAq4yh4kU3aUn8pz/JvxvvAQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZSWuT3n5q2ozNknpy8WUd1twLQsdL7ZzRAmlWG5YRgSpQ0R8rcymLXQSbx2kk79jtyAMIblclArL1A6ACVLPLsknNYQ2z1lS8Ynbp/JXeyTa5+5YLDjdWw2BUkD1CZPKdyRULOLGjDzintEfRfLRyEObXG4wzeMJfTPwTRbw7Iw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cda9TNgD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cda9TNgD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DC2AC2BCB4; Mon, 13 Apr 2026 16:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776096243; bh=u3t8ySsbIJ9VKPPe97ZZAq4yh4kU3aUn8pz/JvxvvAQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cda9TNgDZCHBPG2E8Q77rOsDnEXL8JDzqDXmKH2wy4GYzmkgaAzPmDZbZdZAdPC96 SExwQRIWV+UcMvAzd0vviIFHfpYIAbSILzOi2VwtXDGxynkrw2dLX8Sg9k3hEK0QEV 1nJMHO1nsHBJ4Pt66+zSsxJCH/Ai+5VXFVOZC4j4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yasuaki Torimaru , Simon Horman , Breno Leitao , Steffen Klassert Subject: [PATCH 6.19 22/86] xfrm: clear trailing padding in build_polexpire() Date: Mon, 13 Apr 2026 17:59:29 +0200 Message-ID: <20260413155732.406752080@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155731.568515178@linuxfoundation.org> References: <20260413155731.568515178@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yasuaki Torimaru commit 71a98248c63c535eaa4d4c22f099b68d902006d0 upstream. build_expire() clears the trailing padding bytes of struct xfrm_user_expire after setting the hard field via memset_after(), but the analogous function build_polexpire() does not do this for struct xfrm_user_polexpire. The padding bytes after the __u8 hard field are left uninitialized from the heap allocation, and are then sent to userspace via netlink multicast to XFRMNLGRP_EXPIRE listeners, leaking kernel heap memory contents. Add the missing memset_after() call, matching build_expire(). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Yasuaki Torimaru Reviewed-by: Simon Horman Reviewed-by: Breno Leitao Signed-off-by: Steffen Klassert Signed-off-by: Greg Kroah-Hartman --- net/xfrm/xfrm_user.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -3951,6 +3951,8 @@ static int build_polexpire(struct sk_buf return err; } upe->hard = !!hard; + /* clear the padding bytes */ + memset_after(upe, 0, hard); nlmsg_end(skb, nlh); return 0;