From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55AD127FB2E; Mon, 13 Apr 2026 16:06:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776096367; cv=none; b=cSIDcg3GB7whN9bPXD2sG1nv+xDpxQUCt4+SInc0o+KET/hbHhDimN0hM159hGi6NW1P4Elu3SIjD/slsPHzrHXYwwiVsOnJMafhPQ6NYNMT57Asl+dr8Wpl6XaUYLnn5nL3+l4BSZ0uIcniOVcHlyV0Sqg/ik1s06hsYLoug80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776096367; c=relaxed/simple; bh=TFPpvnxej/Yy+VJeJfJafF1AV4t2k4/rqBf2+uYQztc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o+hH36RKqQL8OgkL+UfrAir1PQsFu265+xq9mUaNq+G+1yAYjSMfv44DxK4AnPa/Nz8ZnlCdZHf6Nnm1wDhgxziuNTS4FjjDr7rYc3RKamXEFU7zJbI/ZYxReYDSBMXrmYWNGMTycTIkoj2l9jXOLkh1Yun/FSc9ePPtN8fO+UY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=y/htytE7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="y/htytE7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E17BBC2BCAF; Mon, 13 Apr 2026 16:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776096367; bh=TFPpvnxej/Yy+VJeJfJafF1AV4t2k4/rqBf2+uYQztc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y/htytE7Id5enaTmZDcwU3yUNnjsariAMZsKAIGzbGInz6lcFwafm4CP4WwRlZLqB s5lBpoBru2sSZ9NiScxZy1KrQxwIzfiAvL6VVUXI9hGCGRGvUufHAgrFcPnGKM3kML Qn5XDywRE+n0lWHDQk1L2dPLUXcXvqgFDFz+oZY4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pengpeng Hou , Paolo Abeni Subject: [PATCH 6.19 38/86] nfc: pn533: allocate rx skb before consuming bytes Date: Mon, 13 Apr 2026 17:59:45 +0200 Message-ID: <20260413155732.990535157@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155731.568515178@linuxfoundation.org> References: <20260413155731.568515178@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pengpeng Hou commit c71ba669b570c7b3f86ec875be222ea11dacb352 upstream. pn532_receive_buf() reports the number of accepted bytes to the serdev core. The current code consumes bytes into recv_skb and may already hand a complete frame to pn533_recv_frame() before allocating a fresh receive buffer. If that alloc_skb() fails, the callback returns 0 even though it has already consumed bytes, and it leaves recv_skb as NULL for the next receive callback. That breaks the receive_buf() accounting contract and can also lead to a NULL dereference on the next skb_put_u8(). Allocate the receive skb lazily before consuming the next byte instead. If allocation fails, return the number of bytes already accepted. Fixes: c656aa4c27b1 ("nfc: pn533: add UART phy driver") Cc: stable@vger.kernel.org Signed-off-by: Pengpeng Hou Link: https://patch.msgid.link/20260405094003.3-pn533-v2-pengpeng@iscas.ac.cn Signed-off-by: Paolo Abeni Signed-off-by: Greg Kroah-Hartman --- drivers/nfc/pn533/uart.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) --- a/drivers/nfc/pn533/uart.c +++ b/drivers/nfc/pn533/uart.c @@ -211,6 +211,13 @@ static size_t pn532_receive_buf(struct s timer_delete(&dev->cmd_timeout); for (i = 0; i < count; i++) { + if (!dev->recv_skb) { + dev->recv_skb = alloc_skb(PN532_UART_SKB_BUFF_LEN, + GFP_KERNEL); + if (!dev->recv_skb) + return i; + } + if (unlikely(!skb_tailroom(dev->recv_skb))) skb_trim(dev->recv_skb, 0); @@ -219,9 +226,7 @@ static size_t pn532_receive_buf(struct s continue; pn533_recv_frame(dev->priv, dev->recv_skb, 0); - dev->recv_skb = alloc_skb(PN532_UART_SKB_BUFF_LEN, GFP_KERNEL); - if (!dev->recv_skb) - return 0; + dev->recv_skb = NULL; } return i;