From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BD6F2E2850; Mon, 13 Apr 2026 16:44:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776098660; cv=none; b=E8eu8CtvlgOAy1ESdK0GEnXaOkWeshcZfwPy0H88SHCIeUxrIobFK/E7oxtzoRO+C+ePuUx9igP82rWfLGHPY/UfWqbhudDyawJ7hg85i4DIoZre5eYLyY7Wws/OiM4y0UK6ejW8MJRwNRP90TViRjGD5d1tFCW0cBvmTjp2Tvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776098660; c=relaxed/simple; bh=6z9LKQk6nHaEIjgTX/XpFD/r+XCSCjCH66LTdlHd9cs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OgUzyfiZKtYJ3jGHGQhOaO4joQO/MuRhe9HjENy1EmjgEqOT8Nu37Cu6HFMd4wE5o+KZ8eC/wN4TnBxS0plv3MPj8R2VaZk6Oac/k86kU2cNQDCdZJrZxW/rRLLduT1ng+4695TDmhjh53OBtvUJ8k87F6WNh5mo/g+yQxu85Zo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Jxk1bHjt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Jxk1bHjt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11119C2BCAF; Mon, 13 Apr 2026 16:44:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776098660; bh=6z9LKQk6nHaEIjgTX/XpFD/r+XCSCjCH66LTdlHd9cs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jxk1bHjtXl7bT6wPmdj305UtjqpFNqZyYZp+l8YYKrZRQg4dfoYSVYukCDiBY2Lsc oeyAuINy2zF+FN9Jg57w0AZnljhyuin3x6LLXe8f4FCSafHRGhLHIt6UWf/aamgUEO YFGfKdQWgpgZ4dVLLWK4bAztY+rkmMqHK1oUtqdA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wentao Liang , Andreas Kemnade , Kevin Hilman , Sasha Levin Subject: [PATCH 5.10 008/491] ARM: omap2: Fix reference count leaks in omap_control_init() Date: Mon, 13 Apr 2026 17:54:13 +0200 Message-ID: <20260413155819.363255989@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wentao Liang [ Upstream commit 93a04ab480c8bbcb7d9004be139c538c8a0c1bc8 ] The of_get_child_by_name() function increments the reference count of child nodes, causing multiple reference leaks in omap_control_init(): 1. scm_conf node never released in normal/error paths 2. clocks node leak when checking existence 3. Missing scm_conf release before np in error paths Fix these leaks by adding proper of_node_put() calls and separate error handling. Fixes: e5b635742e98 ("ARM: OMAP2+: control: add syscon support for register accesses") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang Reviewed-by: Andreas Kemnade Link: https://patch.msgid.link/20251217142122.1861292-1-vulab@iscas.ac.cn Signed-off-by: Kevin Hilman Signed-off-by: Sasha Levin --- arch/arm/mach-omap2/control.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/control.c b/arch/arm/mach-omap2/control.c index 9bc69caf338f1..a1288d438071b 100644 --- a/arch/arm/mach-omap2/control.c +++ b/arch/arm/mach-omap2/control.c @@ -798,7 +798,7 @@ int __init omap2_control_base_init(void) */ int __init omap_control_init(void) { - struct device_node *np, *scm_conf; + struct device_node *np, *scm_conf, *clocks_node; const struct of_device_id *match; const struct omap_prcm_init_data *data; int ret; @@ -819,16 +819,19 @@ int __init omap_control_init(void) if (IS_ERR(syscon)) { ret = PTR_ERR(syscon); - goto of_node_put; + goto err_put_scm_conf; } - if (of_get_child_by_name(scm_conf, "clocks")) { + clocks_node = of_get_child_by_name(scm_conf, "clocks"); + if (clocks_node) { + of_node_put(clocks_node); ret = omap2_clk_provider_init(scm_conf, data->index, syscon, NULL); if (ret) - goto of_node_put; + goto err_put_scm_conf; } + of_node_put(scm_conf); } else { /* No scm_conf found, direct access */ ret = omap2_clk_provider_init(np, data->index, NULL, @@ -846,6 +849,9 @@ int __init omap_control_init(void) return 0; +err_put_scm_conf: + if (scm_conf) + of_node_put(scm_conf); of_node_put: of_node_put(np); return ret; -- 2.51.0