From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A24B314D26; Mon, 13 Apr 2026 16:47:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776098841; cv=none; b=MnqzBSlnkpoHd+O6ORx7VBxA01+amUgulFX0sQ7E14pKiCbgtOUsF2WPywss5+Xw+Pf3VI3JbQ4wn+CKa0w9pG1GltVgpc/39UxCaHPNcOMA2irqnEQHqXNocu0aOIWKkmWhqeVt8ZemekvRiTSx26mFKhOzgJ1ayj2zV+LzI0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776098841; c=relaxed/simple; bh=jjPq92rxlN9i9zYua4ZQMEdJVyXnwu1o554g2ffqyOI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S5bm2RdplLzn2RjfDnEB0Qo8E8Be3tqQ+6pNXPbjM5alGsHIrLb/3u1UaOkKW+6k0OiA++Kvy3slVE5GLqKMrmPIkB9ifpXH5Fh9FpQT3+y8UfSVoZ5oH0LJYRcBm7m24ehh20CeiaoHejvOfpJ/eLGhtb5GvIm3CC+G0HXzcUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FXen80Ux; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FXen80Ux" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92BA6C2BCAF; Mon, 13 Apr 2026 16:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776098840; bh=jjPq92rxlN9i9zYua4ZQMEdJVyXnwu1o554g2ffqyOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FXen80UxnVHx/7QX5aBK1v70201GeWLoHGxaYQC1yjG1TFCq+My6VaXKeEQUhh7+c Ys/Jlrji2sCwAD2XendIimDjS3LOd7eXS87iYv3HHrIzsTkE8khpuHAQo+tLozminw pywHhmh/qhsjeCNwNpXphhDpqFH8QetwBWfC+y9Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Dull , Hyunwoo Kim , Florian Westphal , Sasha Levin Subject: [PATCH 5.10 077/491] netfilter: nfnetlink_queue: fix entry leak in bridge verdict error path Date: Mon, 13 Apr 2026 17:55:22 +0200 Message-ID: <20260413155821.928440686@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hyunwoo Kim [ Upstream commit f1ba83755d81c6fc66ac7acd723d238f974091e9 ] nfqnl_recv_verdict() calls find_dequeue_entry() to remove the queue entry from the queue data structures, taking ownership of the entry. For PF_BRIDGE packets, it then calls nfqa_parse_bridge() to parse VLAN attributes. If nfqa_parse_bridge() returns an error (e.g. NFQA_VLAN present but NFQA_VLAN_TCI missing), the function returns immediately without freeing the dequeued entry or its sk_buff. This leaks the nf_queue_entry, its associated sk_buff, and all held references (net_device refcounts, struct net refcount). Repeated triggering exhausts kernel memory. Fix this by dropping the entry via nfqnl_reinject() with NF_DROP verdict on the error path, consistent with other error handling in this file. Fixes: 8d45ff22f1b4 ("netfilter: bridge: nf queue verdict to use NFQA_VLAN and NFQA_L2HDR") Reviewed-by: David Dull Signed-off-by: Hyunwoo Kim Signed-off-by: Florian Westphal Signed-off-by: Sasha Levin --- net/netfilter/nfnetlink_queue.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c index dc6af1919deaf..bfe909267c9d9 100644 --- a/net/netfilter/nfnetlink_queue.c +++ b/net/netfilter/nfnetlink_queue.c @@ -1209,8 +1209,10 @@ static int nfqnl_recv_verdict(struct net *net, struct sock *ctnl, if (entry->state.pf == PF_BRIDGE) { err = nfqa_parse_bridge(entry, nfqa); - if (err < 0) + if (err < 0) { + nfqnl_reinject(entry, NF_DROP); return err; + } } if (nfqa[NFQA_PAYLOAD]) { -- 2.51.0