From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78BC83168EE; Mon, 13 Apr 2026 16:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776098936; cv=none; b=cWOm/jpNStSnag64Rb1KiP4lOEUJ4sRl8stRBZdayvQXHhSqgLPGU8CX50mxHG1jzNAxU19pixvoLFKbqgy4bK699lvTnkB5P4/PRb7kNc+jDHRPXZZOojcAdyba+RUTq4IjoGywuxCWjEKXrD+ZVSi7bx046Uec9k+Gv78RyZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776098936; c=relaxed/simple; bh=KyGRFv4U+MmtwfYvJIsH6egzS4Hi8PWH8/J5nqUvKj8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JIPWZu7A3mNhBWXGOw08BJJUoA6zD6lMRv5643ULQFJZ4nUdyv/7gGiI0XggJxh0sOynsUbSnX/cWe9f5pZXSzWrUfFieUU+pkniD0P+vjgGpJ0p59RmeqaPfcz7w66OX56RP89dyGKEYamBenNeXjME8tKwIR2/PfJkSoqtWNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kC/oZB6B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kC/oZB6B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11810C2BCAF; Mon, 13 Apr 2026 16:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776098936; bh=KyGRFv4U+MmtwfYvJIsH6egzS4Hi8PWH8/J5nqUvKj8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kC/oZB6BPUn/h0AbDZvqdG7SV0ZaydTE0OyhquOxoXtiOFUbTr5Y00y6PwWlzc/h+ CA6NdCvRV+usZXR1hcmkuyuauIpXG8UDNVBmLad7RAhivpyIW9Hp1oOmm0okRoOuDz vK9fC9knZJsERDUXZXw1y1n/89wTlX4S5/2KUEJY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ziyi Guo , stable Subject: [PATCH 5.10 104/491] usb: image: mdc800: kill download URB on timeout Date: Mon, 13 Apr 2026 17:55:49 +0200 Message-ID: <20260413155822.937130058@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ziyi Guo commit 1be3b77de4eb89af8ae2fd6610546be778e25589 upstream. mdc800_device_read() submits download_urb and waits for completion. If the timeout fires and the device has not responded, the function returns without killing the URB, leaving it active. A subsequent read() resubmits the same URB while it is still in-flight, triggering the WARN in usb_submit_urb(): "URB submitted while active" Check the return value of wait_event_timeout() and kill the URB if it indicates timeout, ensuring the URB is complete before its status is inspected or the URB is resubmitted. Similar to - commit 372c93131998 ("USB: yurex: fix control-URB timeout handling") - commit b98d5000c505 ("media: rc: iguanair: handle timeouts") Signed-off-by: Ziyi Guo Cc: stable Link: https://patch.msgid.link/20260209151937.2247202-1-n7l8m4@u.northwestern.edu Signed-off-by: Greg Kroah-Hartman --- drivers/usb/image/mdc800.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/usb/image/mdc800.c +++ b/drivers/usb/image/mdc800.c @@ -731,9 +731,11 @@ static ssize_t mdc800_device_read (struc mutex_unlock(&mdc800->io_lock); return len-left; } - wait_event_timeout(mdc800->download_wait, + retval = wait_event_timeout(mdc800->download_wait, mdc800->downloaded, msecs_to_jiffies(TO_DOWNLOAD_GET_READY)); + if (!retval) + usb_kill_urb(mdc800->download_urb); mdc800->downloaded = 0; if (mdc800->download_urb->status != 0) {