From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF4233168EE; Mon, 13 Apr 2026 16:50:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099027; cv=none; b=TX5UENfPWpd3BIXxE3mW27UPV5+QsJ2i+mc6Jx46WM+dSSP5+HIMSex+Sy3a3T6gLFNxLbVnJY07MQXaZoBFN2EfHGJPG4fhvdI3sblvwxZBzGyNNcCm6Brc4MtVG3E6rWV47UrSIBUNtYVxZU8CzD/Fl4wZcWI9FC+2dbs3UFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099027; c=relaxed/simple; bh=l0dZRPgkZ03uFSNYX1Xg5SKGwZCqp2bMc19abROrKTw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QFBVAW6h9/GrNVQm2b4OSUqjLTjIDdVLZFwDDZ0NBEKXqMz9u2V3IdRSxA8mEPQSUJFSwB7Q2/p273/EMxlQ7rI8egCHbfpXD/LfMiUboZpsUYYuSVDy3Tw7T0D71BuTz1ld1ElSxCceCiVdaqZk0GnjW0mODK4alsy36FcPbUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TBaiFprj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TBaiFprj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C9FDC2BCAF; Mon, 13 Apr 2026 16:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099026; bh=l0dZRPgkZ03uFSNYX1Xg5SKGwZCqp2bMc19abROrKTw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TBaiFprjz8g12jxAyzdYQnqHQDUNJ+ozUIO2QUqcl/pFwkE+gtuTJbojEHMK4JuFo UioR6js+bXd6fHI8Ib177y1VRpF/7KGcnw6vKlNgbqlLjVKGkw7yb9+//Uth1ru9aW OPl5TmIeiLcrmNV31fVY3cEi/0PvU9s/MtGe2GhE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dingisoul , Dave Jiang , Ira Weiny Subject: [PATCH 5.10 139/491] nvdimm/bus: Fix potential use after free in asynchronous initialization Date: Mon, 13 Apr 2026 17:56:24 +0200 Message-ID: <20260413155824.243546320@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ira Weiny commit a8aec14230322ed8f1e8042b6d656c1631d41163 upstream. Dingisoul with KASAN reports a use after free if device_add() fails in nd_async_device_register(). Commit b6eae0f61db2 ("libnvdimm: Hold reference on parent while scheduling async init") correctly added a reference on the parent device to be held until asynchronous initialization was complete. However, if device_add() results in an allocation failure the ref count of the device drops to 0 prior to the parent pointer being accessed. Thus resulting in use after free. The bug bot AI correctly identified the fix. Save a reference to the parent pointer to be used to drop the parent reference regardless of the outcome of device_add(). Reported-by: Dingisoul Closes: http://lore.kernel.org/8855544b-be9e-4153-aa55-0bc328b13733@gmail.com Fixes: b6eae0f61db2 ("libnvdimm: Hold reference on parent while scheduling async init") Cc: stable@vger.kernel.org Reviewed-by: Dave Jiang Link: https://patch.msgid.link/20260306-fix-uaf-async-init-v1-1-a28fd7526723@intel.com Signed-off-by: Ira Weiny Signed-off-by: Greg Kroah-Hartman --- drivers/nvdimm/bus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/nvdimm/bus.c +++ b/drivers/nvdimm/bus.c @@ -502,14 +502,15 @@ EXPORT_SYMBOL_GPL(nd_synchronize); static void nd_async_device_register(void *d, async_cookie_t cookie) { struct device *dev = d; + struct device *parent = dev->parent; if (device_add(dev) != 0) { dev_err(dev, "%s: failed\n", __func__); put_device(dev); } put_device(dev); - if (dev->parent) - put_device(dev->parent); + if (parent) + put_device(parent); } static void nd_async_device_unregister(void *d, async_cookie_t cookie)