From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FAB23161AB; Mon, 13 Apr 2026 16:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099096; cv=none; b=QDL+YZw38GW05WWH63LPy2Lu04SLx9d1W/qs7AGKl5yv/4oVUzWLXbV/eVRZLxjYgZZZKQWOsaPm82NwaX4eJMOd/E/a+GtAFrH18lV11aSnn3EQQr7+4mYnB1egaBMGlcD4At9OTKyI1GAjYnklT2nX3wUoSgB+5yyMnZLYLtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099096; c=relaxed/simple; bh=XJT6xTMO9+YqgCUynZ7SdHz5hZmInbwOqWOMN+iJqno=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I1vlE1Ssu/Efl8Cl5fubNvNWmseLZWBUfuMN7HPavmeUa8IsnByQCrh0AQxdDZIOl0jX/uobru8YP3nkVL93wpBfrzugdM1tvj8MlDvDF+RQStRaPDg+VOoAd+kXua/kxfomh6ri79FsFd9Md7xNpUL8Wv017uchH+WZbcVx7SQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=H869WTz7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="H869WTz7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAD05C2BCAF; Mon, 13 Apr 2026 16:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099096; bh=XJT6xTMO9+YqgCUynZ7SdHz5hZmInbwOqWOMN+iJqno=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H869WTz7F0lv2FM2mAPi+QYy+Db/wnkpnr59m/kCjKSI0T/buFvk3DQ1OiNauOhXe VZUKljTM8bMKchbKbziQzgkI+prOduLCx9DK9G5RJ556+qldvEFURSS3T2aDkTIAF1 nYQxbHY1WwVDJCCiYByKpwGp2FcldkY+qwM9C6hA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Lukas=20Johannes=20M=C3=B6ller?= , Florian Westphal , Sasha Levin Subject: [PATCH 5.10 207/491] netfilter: nf_conntrack_sip: fix Content-Length u32 truncation in sip_help_tcp() Date: Mon, 13 Apr 2026 17:57:32 +0200 Message-ID: <20260413155826.819623718@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lukas Johannes Möller [ Upstream commit fbce58e719a17aa215c724473fd5baaa4a8dc57c ] sip_help_tcp() parses the SIP Content-Length header with simple_strtoul(), which returns unsigned long, but stores the result in unsigned int clen. On 64-bit systems, values exceeding UINT_MAX are silently truncated before computing the SIP message boundary. For example, Content-Length 4294967328 (2^32 + 32) is truncated to 32, causing the parser to miscalculate where the current message ends. The loop then treats trailing data in the TCP segment as a second SIP message and processes it through the SDP parser. Fix this by changing clen to unsigned long to match the return type of simple_strtoul(), and reject Content-Length values that exceed the remaining TCP payload length. Fixes: f5b321bd37fb ("netfilter: nf_conntrack_sip: add TCP support") Signed-off-by: Lukas Johannes Möller Signed-off-by: Florian Westphal Signed-off-by: Sasha Levin --- net/netfilter/nf_conntrack_sip.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c index 751df19fe0f8a..5db17768ec2ad 100644 --- a/net/netfilter/nf_conntrack_sip.c +++ b/net/netfilter/nf_conntrack_sip.c @@ -1529,11 +1529,12 @@ static int sip_help_tcp(struct sk_buff *skb, unsigned int protoff, { struct tcphdr *th, _tcph; unsigned int dataoff, datalen; - unsigned int matchoff, matchlen, clen; + unsigned int matchoff, matchlen; unsigned int msglen, origlen; const char *dptr, *end; s16 diff, tdiff = 0; int ret = NF_ACCEPT; + unsigned long clen; bool term; if (ctinfo != IP_CT_ESTABLISHED && @@ -1568,6 +1569,9 @@ static int sip_help_tcp(struct sk_buff *skb, unsigned int protoff, if (dptr + matchoff == end) break; + if (clen > datalen) + break; + term = false; for (; end + strlen("\r\n\r\n") <= dptr + datalen; end++) { if (end[0] == '\r' && end[1] == '\n' && -- 2.51.0