From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DB53313298; Mon, 13 Apr 2026 16:53:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099217; cv=none; b=t/qAF9eWx1BMwBzqCHpAxAAatA8krjsEhp6X8U03b8HDZXKh2LL0Ir19bEZ9fDOkrS+hrVVfaGFkeY/uy37i++9Gta/mu5ZVlx+rneFWAA/6A7t7Yyjju0X8BCHhVcqzkY6m3uefr3FlxaU8VXqhERvNnWCPO0NItIM/RK6lu9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099217; c=relaxed/simple; bh=Y6mi3CIInFwTPuZXfPESwvPhDM5oLPDO7JqzCgcbVP4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MeXrsaGD7g5Trk75+xHH1pUSHdTau/s4fLfEUBgpytMwpJcbA95LuO7rFeQ2dlJKQvC0tBbH2fakeVrwSEQ/PnhUYktY+pAae0SUiyCkRGAGEqzqCqHa2CVtR74clVrw3tfSz7wyEr86b4txrPraYNqUbi+0XSnf78uo7YJwQqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2LeoUyeM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2LeoUyeM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1414EC2BCAF; Mon, 13 Apr 2026 16:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099217; bh=Y6mi3CIInFwTPuZXfPESwvPhDM5oLPDO7JqzCgcbVP4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2LeoUyeM9UJZc2DL9ramoMcjh4IOOxkzNxtBjctPXisO7Diw2pPZ48PP+ULFg7s48 vVbp+z8r4iwPHi4CRNr9wOwLtFY20rNDShnBLV+3um9gcVFX3kFzq81aMTxAz2ueD2 jedVVELcGlZ/93vpftOTNj/SVyfgVRwTH02Lqj0o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ian Ray , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 256/491] nfc: nci: fix circular locking dependency in nci_close_device Date: Mon, 13 Apr 2026 17:58:21 +0200 Message-ID: <20260413155828.636557312@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jakub Kicinski [ Upstream commit 4527025d440ce84bf56e75ce1df2e84cb8178616 ] nci_close_device() flushes rx_wq and tx_wq while holding req_lock. This causes a circular locking dependency because nci_rx_work() running on rx_wq can end up taking req_lock too: nci_rx_work -> nci_rx_data_packet -> nci_data_exchange_complete -> __sk_destruct -> rawsock_destruct -> nfc_deactivate_target -> nci_deactivate_target -> nci_request -> mutex_lock(&ndev->req_lock) Move the flush of rx_wq after req_lock has been released. This should safe (I think) because NCI_UP has already been cleared and the transport is closed, so the work will see it and return -ENETDOWN. NIPA has been hitting this running the nci selftest with a debug kernel on roughly 4% of the runs. Fixes: 6a2968aaf50c ("NFC: basic NCI protocol implementation") Reviewed-by: Ian Ray Link: https://patch.msgid.link/20260317193334.988609-1-kuba@kernel.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/nfc/nci/core.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c index 873c9073e4111..78472b1929705 100644 --- a/net/nfc/nci/core.c +++ b/net/nfc/nci/core.c @@ -562,8 +562,7 @@ static int nci_close_device(struct nci_dev *ndev) skb_queue_purge(&ndev->rx_q); skb_queue_purge(&ndev->tx_q); - /* Flush RX and TX wq */ - flush_workqueue(ndev->rx_wq); + /* Flush TX wq, RX wq flush can't be under the lock */ flush_workqueue(ndev->tx_wq); /* Reset device */ @@ -575,13 +574,13 @@ static int nci_close_device(struct nci_dev *ndev) msecs_to_jiffies(NCI_RESET_TIMEOUT)); /* After this point our queues are empty - * and no works are scheduled. + * rx work may be running but will see that NCI_UP was cleared */ ndev->ops->close(ndev); clear_bit(NCI_INIT, &ndev->flags); - /* Flush cmd wq */ + /* Flush cmd and tx wq */ flush_workqueue(ndev->cmd_wq); del_timer_sync(&ndev->cmd_timer); @@ -591,6 +590,9 @@ static int nci_close_device(struct nci_dev *ndev) mutex_unlock(&ndev->req_lock); + /* rx_work may take req_lock via nci_deactivate_target */ + flush_workqueue(ndev->rx_wq); + return 0; } -- 2.51.0