From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2AE5313298; Mon, 13 Apr 2026 16:53:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099227; cv=none; b=Jbw8YWprrJK7DHb88Mgjz9Lze8uLvJcTN5RXRh3ykoJyVoad6Si6PJ+fN1mxzwWNdrql3Spgz6RCGXSX+OdhVfy5MYp8uuCc5krO31XCm/WM5GkJuZVchoeGOziEbqxFa86SQgMXW8rv7xirTvXl+QHEMrvLSDZByjDHUAmJSZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099227; c=relaxed/simple; bh=f0jajwAYmPCaQdvXsZzhbOqqTMG/SSLUmTobGCPsXuE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dY4sJo+sSOyuPe13JjvKN2nAYRzmO0HOQvo0mug6y9S1qPYEGtoHY9hQc1AvN1UjXRHauApWqE0LrqhO/u+0ip2dmHC2SNlqR7RzKhd0PEspuCtBtLQddf2F08mg5KfWx5Chk/sHQQWt/P/AdJIaGfj35DeNwLlIvkktfUBQdWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AFvE7idV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AFvE7idV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57778C2BCB3; Mon, 13 Apr 2026 16:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099227; bh=f0jajwAYmPCaQdvXsZzhbOqqTMG/SSLUmTobGCPsXuE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AFvE7idVPUXy20ss1j9IbLm9vSqs6PYwSIoRXaN2XY+dmfsGG0q3r293y41XI8SBc defsVbfTwIn2qv9/nHD09YJjVfH1LzFo8fGWB8zRhFJ/tUrZTdQjhtkwnywjawnKG4 26L2h2yAZoF31Xk+GGSQm4j568GgezB1yFiD9ZAw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jiri Pirko , Sabrina Dubroca , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 260/491] rtnetlink: count IFLA_INFO_SLAVE_KIND in if_nlmsg_size Date: Mon, 13 Apr 2026 17:58:25 +0200 Message-ID: <20260413155828.785987585@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sabrina Dubroca [ Upstream commit ee00a12593ffb69db4dd1a1c00ecb0253376874a ] rtnl_link_get_slave_info_data_size counts IFLA_INFO_SLAVE_DATA, but rtnl_link_slave_info_fill adds both IFLA_INFO_SLAVE_DATA and IFLA_INFO_SLAVE_KIND. Fixes: ba7d49b1f0f8 ("rtnetlink: provide api for getting and setting slave info") Reviewed-by: Jiri Pirko Signed-off-by: Sabrina Dubroca Link: https://patch.msgid.link/049843b532e23cde7ddba263c0bbe35ba6f0d26d.1773919462.git.sd@queasysnail.net Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/core/rtnetlink.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 99337557408b5..c58510d7ea0d8 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -501,11 +501,14 @@ static size_t rtnl_link_get_slave_info_data_size(const struct net_device *dev) goto out; ops = master_dev->rtnl_link_ops; - if (!ops || !ops->get_slave_size) + if (!ops) + goto out; + size += nla_total_size(strlen(ops->kind) + 1); /* IFLA_INFO_SLAVE_KIND */ + if (!ops->get_slave_size) goto out; /* IFLA_INFO_SLAVE_DATA + nested data */ - size = nla_total_size(sizeof(struct nlattr)) + - ops->get_slave_size(master_dev, dev); + size += nla_total_size(sizeof(struct nlattr)) + + ops->get_slave_size(master_dev, dev); out: rcu_read_unlock(); -- 2.51.0