From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73DCC3314DE; Mon, 13 Apr 2026 16:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099460; cv=none; b=Ly5F252prQizq6ijcn2nAQztbDctr6LIySxT28SSmdlXvPhbp+zFLZbl4HS5pLppm20BBg0EZDxoVu4+0t8uKrf6eY/6F1bC1UszilovalYNXxklLn2mmkA5lQckaRtLrS/e8HBKgRH3bsFOz883fKuTY0RnYejV1J1LsUOr+1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099460; c=relaxed/simple; bh=wg2YxpuLjSYgzl1iBzyjyCmTH2Di5Bjz/7mX1sM6kr4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r1ouc68OkBZvBU8Ib5+wmM4hlmBvfzP3VGAYUyZKYxS90Tj9F1WfPfistGaFQ78+pP8dVpTIFNlEntQWhSqMWYqB5ZHkfLj0xkxO88R8qLtXRabZsEKzZgmzhM9LkS84WD5lhlUbE7aizVKjWNiOFZfifZCtTVo+dvfcHTY3aW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jJy0CQhB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jJy0CQhB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 091B1C2BCAF; Mon, 13 Apr 2026 16:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099460; bh=wg2YxpuLjSYgzl1iBzyjyCmTH2Di5Bjz/7mX1sM6kr4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jJy0CQhBtHBb1btR8BeBhJ9ysI7X+3uw0w8WKB8/sDq1kTsV37cPQ3HsogX9m3+Cg pHRQ+IS2oRLpPf5m0aCl85Ge/EryD2IRWPHeYw13l9e3pf1H1IC6RpK6QoAp+ASnGZ b4MTCCs7jSiBiksaGM1fOiMpir1Ks5HtXoVwnKa8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fedor Pchelkin , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 347/491] net: macb: properly unregister fixed rate clocks Date: Mon, 13 Apr 2026 17:59:52 +0200 Message-ID: <20260413155832.029826927@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fedor Pchelkin [ Upstream commit f0f367a4f459cc8118aadc43c6bba53c60d93f8d ] The additional resources allocated with clk_register_fixed_rate() need to be released with clk_unregister_fixed_rate(), otherwise they are lost. Fixes: 83a77e9ec415 ("net: macb: Added PCI wrapper for Platform Driver.") Signed-off-by: Fedor Pchelkin Link: https://patch.msgid.link/20260330184542.626619-2-pchelkin@ispras.ru Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/cadence/macb_pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_pci.c b/drivers/net/ethernet/cadence/macb_pci.c index 9be050c5d83e0..e6c17e0af1ccf 100644 --- a/drivers/net/ethernet/cadence/macb_pci.c +++ b/drivers/net/ethernet/cadence/macb_pci.c @@ -97,10 +97,10 @@ static int macb_probe(struct pci_dev *pdev, const struct pci_device_id *id) return 0; err_plat_dev_register: - clk_unregister(plat_data.hclk); + clk_unregister_fixed_rate(plat_data.hclk); err_hclk_register: - clk_unregister(plat_data.pclk); + clk_unregister_fixed_rate(plat_data.pclk); err_pclk_register: return err; @@ -114,8 +114,8 @@ static void macb_remove(struct pci_dev *pdev) struct clk *hclk = plat_data->hclk; platform_device_unregister(plat_dev); - clk_unregister(pclk); - clk_unregister(hclk); + clk_unregister_fixed_rate(pclk); + clk_unregister_fixed_rate(hclk); } static const struct pci_device_id dev_id_table[] = { -- 2.53.0