From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A06D332863D; Mon, 13 Apr 2026 16:58:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099522; cv=none; b=P2ZIbt0iPQyz4NQqBvXhutppRWyfpkHMT31aXVirmtLdycp7HV9+T3gs7E/+pNMz+E48R0FPVIKrm2dRVHP/5Kcjjz3OyMvIY3wCfATai6jeVVbGMjnNKHLJBnOzh/8y6BumsM7ckBMSBVNYS3jycnyHjwnEpobmaekkjgWUy/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099522; c=relaxed/simple; bh=VtnmLQvSr68gshyIjsTOyerjd2o00NUzp2xpMuUzErE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tyol27nZnIENXtDbUi3M950nZZSSY2dyT5KpS6trm6WznMQu1EpoLaJo7/UCEHmlcNmTNivMgRwbRb9M4XDiYPDNkEcWNSWzbxiqYbRsg3rAPZf8Z7P8cUr4TDDMUY2RgpIFngKBS6TADUuc8+rIlvkjOkF9BTNt/6XcfuyiVxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Ns71F+ds; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Ns71F+ds" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E89E5C2BCAF; Mon, 13 Apr 2026 16:58:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099522; bh=VtnmLQvSr68gshyIjsTOyerjd2o00NUzp2xpMuUzErE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ns71F+dsNnYZq/aF1hS+gw1z/QAZwRTLL8ZTz6QHdH18h1ojsXuPqX6Osm1czHfkt KP1NV9NX/u7AswiNfKt8i2kQgChiBdQbfKnF3GXX5i+jyIXpKKOc6BcetlwBvtMyVf rVwVgWwtGh6oYjxsDwj7lCcv98/w6yKPO7rPfNmU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sanman Pradhan , Guenter Roeck Subject: [PATCH 5.10 372/491] hwmon: (occ) Fix division by zero in occ_show_power_1() Date: Mon, 13 Apr 2026 18:00:17 +0200 Message-ID: <20260413155832.961213778@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sanman Pradhan commit 39e2a5bf970402a8530a319cf06122e216ba57b8 upstream. In occ_show_power_1() case 1, the accumulator is divided by update_tag without checking for zero. If no samples have been collected yet (e.g. during early boot when the sensor block is included but hasn't been updated), update_tag is zero, causing a kernel divide-by-zero crash. The 2019 fix in commit 211186cae14d ("hwmon: (occ) Fix division by zero issue") only addressed occ_get_powr_avg() used by occ_show_power_2() and occ_show_power_a0(). This separate code path in occ_show_power_1() was missed. Fix this by reusing the existing occ_get_powr_avg() helper, which already handles the zero-sample case and uses mul_u64_u32_div() to multiply before dividing for better precision. Move the helper above occ_show_power_1() so it is visible at the call site. Fixes: c10e753d43eb ("hwmon (occ): Add sensor types and versions") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan Link: https://lore.kernel.org/r/20260326224510.294619-2-sanman.pradhan@hpe.com [groeck: Fix alignment problems reported by checkpatch] Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/occ/common.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) --- a/drivers/hwmon/occ/common.c +++ b/drivers/hwmon/occ/common.c @@ -422,6 +422,12 @@ static ssize_t occ_show_freq_2(struct de return sysfs_emit(buf, "%u\n", val); } +static u64 occ_get_powr_avg(u64 accum, u32 samples) +{ + return (samples == 0) ? 0 : + mul_u64_u32_div(accum, 1000000UL, samples); +} + static ssize_t occ_show_power_1(struct device *dev, struct device_attribute *attr, char *buf) { @@ -443,9 +449,8 @@ static ssize_t occ_show_power_1(struct d val = get_unaligned_be16(&power->sensor_id); break; case 1: - val = get_unaligned_be32(&power->accumulator) / - get_unaligned_be32(&power->update_tag); - val *= 1000000ULL; + val = occ_get_powr_avg(get_unaligned_be32(&power->accumulator), + get_unaligned_be32(&power->update_tag)); break; case 2: val = (u64)get_unaligned_be32(&power->update_tag) * @@ -461,12 +466,6 @@ static ssize_t occ_show_power_1(struct d return sysfs_emit(buf, "%llu\n", val); } -static u64 occ_get_powr_avg(u64 accum, u32 samples) -{ - return (samples == 0) ? 0 : - mul_u64_u32_div(accum, 1000000UL, samples); -} - static ssize_t occ_show_power_2(struct device *dev, struct device_attribute *attr, char *buf) {