From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91BF331F9BC; Mon, 13 Apr 2026 16:59:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099594; cv=none; b=qNjFiqufCuzXi1vh3cH0zY7TZoHSanoANKuOh9U86hVbWzAeXx7OPUPji0BxGwKWfC+dvr2CrC5cGPqzX5twt9tsUWu3unaqL8kyb+lGdEXHDzKMOU1OvmHbRG5BvMy6o4AK3bh2Tg38lDxEO5IBXzDtmNDKD5Z7En6iTdunC84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099594; c=relaxed/simple; bh=pH3DiRAWrTN3XV9VIZmfMxjyFSkKoTkfl9PINllhIvg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nhzQ303nWqVQdaN60rjoDARVTzr00i5wJZF2Z3sRNdtc/6UJD87Yfe6wZcLu4F+IyjD1caXaz2krFhH5VjHRLZRwij+C8hyBJdaWVLecdxzQGRWvyzZQ24Z7aQEsF+XTJgQ1MGTpgEMbHpJSp0u/OwkhMg0QkY766n5mgIu0wvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AeiYl8kl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AeiYl8kl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E13E5C2BCAF; Mon, 13 Apr 2026 16:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099594; bh=pH3DiRAWrTN3XV9VIZmfMxjyFSkKoTkfl9PINllhIvg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AeiYl8klWSs8py6UKln5MFBo8dCTcAuclT01XEYWFfACIfQi5R6qYgO4gcioK33NN pq4dpo0RzyGigqsUQKR0evTgig2Cf2Y4g3HsDhCgsaYbcZNcdpqKL6dKcg65U9CtFa ZYaRK866G7S0FfZYeTp733b1NeyhN1+XykI9H5Lo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Ian Abbott Subject: [PATCH 5.10 401/491] comedi: me4000: Fix potential overrun of firmware buffer Date: Mon, 13 Apr 2026 18:00:46 +0200 Message-ID: <20260413155834.044620735@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ian Abbott commit 3fb43a7a5b44713f892c58ead2e5f3a1bc9f4ee7 upstream. `me4000_xilinx_download()` loads the firmware that was requested by `request_firmware()`. It is possible for it to overrun the source buffer because it blindly trusts the file format. It reads a data stream length from the first 4 bytes into variable `file_length` and reads the data stream contents of length `file_length` from offset 16 onwards. Add a test to ensure that the supplied firmware is long enough to contain the header and the data stream. On failure, log an error and return `-EINVAL`. Note: The firmware loading was totally broken before commit ac584af59945 ("staging: comedi: me4000: fix firmware downloading"), but that is the most sensible target for this fix. Fixes: ac584af59945 ("staging: comedi: me4000: fix firmware downloading") Cc: stable Signed-off-by: Ian Abbott Link: https://patch.msgid.link/20260205133949.71722-1-abbotti@mev.co.uk Signed-off-by: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me4000.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) --- a/drivers/staging/comedi/drivers/me4000.c +++ b/drivers/staging/comedi/drivers/me4000.c @@ -316,6 +316,18 @@ static int me4000_xilinx_download(struct unsigned int val; unsigned int i; + /* Get data stream length from header. */ + if (size >= 4) { + file_length = (((unsigned int)data[0] & 0xff) << 24) + + (((unsigned int)data[1] & 0xff) << 16) + + (((unsigned int)data[2] & 0xff) << 8) + + ((unsigned int)data[3] & 0xff); + } + if (size < 16 || file_length > size - 16) { + dev_err(dev->class_dev, "Firmware length inconsistency\n"); + return -EINVAL; + } + if (!xilinx_iobase) return -ENODEV; @@ -347,10 +359,6 @@ static int me4000_xilinx_download(struct outl(val, devpriv->plx_regbase + PLX9052_CNTRL); /* Download Xilinx firmware */ - file_length = (((unsigned int)data[0] & 0xff) << 24) + - (((unsigned int)data[1] & 0xff) << 16) + - (((unsigned int)data[2] & 0xff) << 8) + - ((unsigned int)data[3] & 0xff); usleep_range(10, 1000); for (i = 0; i < file_length; i++) {