From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22928335072; Mon, 13 Apr 2026 17:00:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099643; cv=none; b=lN0Rx4ZE5hlrwX5fHv0aU0gYXndxFtAug4kNzAKF88y8unyLLuuMjHj0VasuRv8rSfb2ofCk6E5cxNTmQRnb/iEI8Yh+Ol/d0eI6nlzu1USD36sa6yAVn/56RwWjr47kBvFoG8N+w1hBf9uEZMGkbbBWYoBxrHFrmW/e+qtEDbo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099643; c=relaxed/simple; bh=nmqod8g2k4evwoAGqEYhtRjOhVms+zDaa5r7GEk/ViU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QXbupsmRm2WIicRNFMfYEx7uBCg5rE6CM2q/IJEpgzmkvNtgIQI607wVM2EKbDbD6Vet8WRUC/aEjXRW0XSqBz52N/X3KhWcseGw9x6wG4qQ7RVHnuQ8eBzPjt6EhbyPfK1oIqx8ZX7EbYRsH7PDEHGGqd6//x7W3+ed2VOnVFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VnrY6n1w; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VnrY6n1w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADE60C2BCAF; Mon, 13 Apr 2026 17:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099643; bh=nmqod8g2k4evwoAGqEYhtRjOhVms+zDaa5r7GEk/ViU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VnrY6n1wDSzumhAjtgFCg5ZPNt7Hx1UlTyQCnOpId2tgjPUpjWedovRwIH48zmZPx SHdR5ilQWanMK7M4STkOgKMPreEptbjVMTB8klKuYHuDpQWUoU873u9snGr0M1se5w 5fAuBhDah4wqC3lAKrnYpvdEIJlxIKQ309lN1C+k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mikhail Gavrilov , Dmitry Torokhov Subject: [PATCH 5.10 417/491] Input: uinput - take event lock when submitting FF request "event" Date: Mon, 13 Apr 2026 18:01:02 +0200 Message-ID: <20260413155834.638466669@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Torokhov commit ff14dafde15c11403fac61367a34fea08926e9ee upstream. To avoid racing with FF playback events and corrupting device's event queue take event_lock spinlock when calling uinput_dev_event() when submitting a FF upload or erase "event". Tested-by: Mikhail Gavrilov Link: https://patch.msgid.link/adXkf6MWzlB8LA_s@google.com Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/misc/uinput.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/input/misc/uinput.c +++ b/drivers/input/misc/uinput.c @@ -25,8 +25,10 @@ #include #include #include +#include #include #include +#include #include #include "../input-compat.h" @@ -75,6 +77,8 @@ static int uinput_dev_event(struct input struct uinput_device *udev = input_get_drvdata(dev); struct timespec64 ts; + lockdep_assert_held(&dev->event_lock); + ktime_get_ts64(&ts); udev->buff[udev->head] = (struct input_event) { @@ -146,6 +150,7 @@ static void uinput_request_release_slot( static int uinput_request_send(struct uinput_device *udev, struct uinput_request *request) { + unsigned long flags; int retval = 0; spin_lock(&udev->state_lock); @@ -159,7 +164,9 @@ static int uinput_request_send(struct ui * Tell our userspace application about this new request * by queueing an input event. */ + spin_lock_irqsave(&udev->dev->event_lock, flags); uinput_dev_event(udev->dev, EV_UINPUT, request->code, request->id); + spin_unlock_irqrestore(&udev->dev->event_lock, flags); out: spin_unlock(&udev->state_lock);