From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9690830B53F; Mon, 13 Apr 2026 16:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776097378; cv=none; b=uxjiJtRrBNNPiLYTctIS/p/B8cb46h5elygzMPmVbm506QNMeApYJ5sHOpL/LKAPNZYgj4XjYKL4uOFjx1wd2Gin1rfwfVtS4e8NnhuZ/CQYmwKfJcekMsOVMy02zUOMQVW4pJ0L6eTXOONmChU+lJbHtuIqkclZhNRm109s7xM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776097378; c=relaxed/simple; bh=TkVLe5r6SuowAg02BicD7kso4henzRTPwR7ZArBEO78=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T4eyR1VXev2nMz50hND+dx6FodcQTFkn+9o3k01C83zTcYJ+BoGWG90bS1ggiokglxcEmRBTUnsON3jZV4sYY7CV7Q/cIBGnqDs8EsqsRb3MdXgktsuUOOmjPVR+FYv1exqgC/3UDNnwtb5JCX7+HceDBLySUHPLBVUgu+nllPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=sRPpntCV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="sRPpntCV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5D48C2BCAF; Mon, 13 Apr 2026 16:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776097378; bh=TkVLe5r6SuowAg02BicD7kso4henzRTPwR7ZArBEO78=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sRPpntCVKMQ890pXXrMX6uA8MOLcA59KdttpbThIBHOl8dzyP+hVyd642qeSST8gp Wqn660AuqpRKdyaq8Qa+g2oqS1C86/XUlbJPoAXVU7eUuuTcrib0CsvJMiRWU19Sa2 NLKHuGOhuYq96X0nVRl6RtDyDgS+5nOLrvgHMr1Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jenny Guanni Qu , Florian Westphal , Sasha Levin Subject: [PATCH 5.15 113/570] netfilter: nft_set_pipapo: fix stack out-of-bounds read in pipapo_drop() Date: Mon, 13 Apr 2026 17:54:04 +0200 Message-ID: <20260413155834.677070143@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155830.386096114@linuxfoundation.org> References: <20260413155830.386096114@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jenny Guanni Qu [ Upstream commit d6d8cd2db236a9dd13dbc2d05843b3445cc964b5 ] pipapo_drop() passes rulemap[i + 1].n to pipapo_unmap() as the to_offset argument on every iteration, including the last one where i == m->field_count - 1. This reads one element past the end of the stack-allocated rulemap array (declared as rulemap[NFT_PIPAPO_MAX_FIELDS] with NFT_PIPAPO_MAX_FIELDS == 16). Although pipapo_unmap() returns early when is_last is true without using the to_offset value, the argument is evaluated at the call site before the function body executes, making this a genuine out-of-bounds stack read confirmed by KASAN: BUG: KASAN: stack-out-of-bounds in pipapo_drop+0x50c/0x57c [nf_tables] Read of size 4 at addr ffff8000810e71a4 This frame has 1 object: [32, 160) 'rulemap' The buggy address is at offset 164 -- exactly 4 bytes past the end of the rulemap array. Pass 0 instead of rulemap[i + 1].n on the last iteration to avoid the out-of-bounds read. Fixes: 3c4287f62044 ("nf_tables: Add set type for arbitrary concatenation of ranges") Signed-off-by: Jenny Guanni Qu Signed-off-by: Florian Westphal Signed-off-by: Sasha Levin --- net/netfilter/nft_set_pipapo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c index 863162c823306..c8a5618742381 100644 --- a/net/netfilter/nft_set_pipapo.c +++ b/net/netfilter/nft_set_pipapo.c @@ -1541,6 +1541,7 @@ static void pipapo_drop(struct nft_pipapo_match *m, int i; nft_pipapo_for_each_field(f, i, m) { + bool last = i == m->field_count - 1; int g; for (g = 0; g < f->groups; g++) { @@ -1560,7 +1561,7 @@ static void pipapo_drop(struct nft_pipapo_match *m, } pipapo_unmap(f->mt, f->rules, rulemap[i].to, rulemap[i].n, - rulemap[i + 1].n, i == m->field_count - 1); + last ? 0 : rulemap[i + 1].n, last); if (pipapo_resize(f, f->rules, f->rules - rulemap[i].n)) { /* We can ignore this, a failure to shrink tables down * doesn't make tables invalid. -- 2.51.0