From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB80F302146; Mon, 13 Apr 2026 16:23:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776097391; cv=none; b=km273Akb1If/vVfSm9FyMWOhnGUJdCDwS38bFmjP8AsXgZ/5w+DtTt7AaJCan/gAaV15d5Aehgb30wX1SwJuiCpxldGDjM1oJxWEob6cJGLAod/dw166dg/C7zrXRWdtvMyGHM1wIhYejF+19nEldLnZbiUt5C06gBTVoYdkcfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776097391; c=relaxed/simple; bh=q15BtnfDh7HnwQv6nOVf4hZDkdxc9dtgWfUoL5J9xPY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JYhepu/gBS76DZU/bFjpLVQrzaGxwYdiz3y0RjnV0xzJk4Rxu4heI3LuccvADAKuxTYhWfGlUA6HQasHYYnnJfqb1DdKngvq2a6AX6g1UDJnNQtN+zzU23fX3Q7WekfUjVe3cYUSnO/AGjH+WmoAQl8uipimCxPFete6lUQGwFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Tk6+ePJE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Tk6+ePJE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1DB6C2BCAF; Mon, 13 Apr 2026 16:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776097391; bh=q15BtnfDh7HnwQv6nOVf4hZDkdxc9dtgWfUoL5J9xPY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tk6+ePJEkRXaHdlK6XHmqIY1JfXlKKLsm6kb1aSC1TtHVpJGRYKUChpqLsux4M9uw 1DFpF8D3Ig7LfGS9iLHRzzl3GAXh5VyyRTXCiUu7ZspyGqctBlQ9Cd4dcRijQuGqNY OI8gRt2jkQrCQa/b1JFlCW9hR4Z4uBL8bSb29qcU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yifan Wu , Juefei Pu , Yuan Tan , Xin Liu , Florian Westphal , Sasha Levin Subject: [PATCH 5.15 117/570] netfilter: xt_IDLETIMER: reject rev0 reuse of ALARM timer labels Date: Mon, 13 Apr 2026 17:54:08 +0200 Message-ID: <20260413155834.825985559@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155830.386096114@linuxfoundation.org> References: <20260413155830.386096114@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuan Tan [ Upstream commit 329f0b9b48ee6ab59d1ab72fef55fe8c6463a6cf ] IDLETIMER revision 0 rules reuse existing timers by label and always call mod_timer() on timer->timer. If the label was created first by revision 1 with XT_IDLETIMER_ALARM, the object uses alarm timer semantics and timer->timer is never initialized. Reusing that object from revision 0 causes mod_timer() on an uninitialized timer_list, triggering debugobjects warnings and possible panic when panic_on_warn=1. Fix this by rejecting revision 0 rule insertion when an existing timer with the same label is of ALARM type. Fixes: 68983a354a65 ("netfilter: xtables: Add snapshot of hardidletimer target") Co-developed-by: Yifan Wu Signed-off-by: Yifan Wu Co-developed-by: Juefei Pu Signed-off-by: Juefei Pu Signed-off-by: Yuan Tan Signed-off-by: Xin Liu Signed-off-by: Florian Westphal Signed-off-by: Sasha Levin --- net/netfilter/xt_IDLETIMER.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/netfilter/xt_IDLETIMER.c b/net/netfilter/xt_IDLETIMER.c index a097686adbbd7..ba831c0e6d11e 100644 --- a/net/netfilter/xt_IDLETIMER.c +++ b/net/netfilter/xt_IDLETIMER.c @@ -320,6 +320,12 @@ static int idletimer_tg_checkentry(const struct xt_tgchk_param *par) info->timer = __idletimer_tg_find_by_label(info->label); if (info->timer) { + if (info->timer->timer_type & XT_IDLETIMER_ALARM) { + pr_debug("Adding/Replacing rule with same label and different timer type is not allowed\n"); + mutex_unlock(&list_mutex); + return -EINVAL; + } + info->timer->refcnt++; mod_timer(&info->timer->timer, msecs_to_jiffies(info->timeout * 1000) + jiffies); -- 2.51.0