From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3FD83368B5; Mon, 13 Apr 2026 17:02:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099772; cv=none; b=MQk9EYJ/uCRyLyeWstwZwDhGfGSg48hqZgMN+5AlHYzdw/kAJ78WrRQsigDqYDDHqPdpBGZApV07DvQhbYpQyJIQZZhQowcw9Bxt5gVOea9Q+W1trALHbiF43654KblYtnZuU65kVltX3o0HVGSXuEvcWPODXtQJfuHKCSWyv6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099772; c=relaxed/simple; bh=S+E3TiHvJrozirY1D8Exa8NA1AxJ/FRw/egB0qBO9w8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QFNi0aWGs/gOV38vBb2BnPf7VbuI1o1ge+Hm0+MFS55ELe4JuPgtDHaaPUWVkH3EYV2Juhk4F3uHhUiPtvPTq2ay/Ed9p6vwrdtIx7Uuh8Ppboqj+jKo/rWrMBJwuvlCmhT9wo1hyr1P5m7vLlg5buhCfwcXsx2bKvTsG38qcs0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kQSyjbL1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kQSyjbL1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30CEBC2BCAF; Mon, 13 Apr 2026 17:02:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099772; bh=S+E3TiHvJrozirY1D8Exa8NA1AxJ/FRw/egB0qBO9w8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kQSyjbL18CKqlVcbqE5Xs0HVpAadF+OJ6rDE+Pcs8JcuYzUfsRK135C96xOb4KF0g u9aNmIEFz/Z4Z5KJ3Jul331eELnchTw0hIyLOxIX0O3DDDOuniuDsGOt9cevZQ0OEz hc++9Ta6ehXTN/e/IDLOGlDKYMcPZLBpTbYsYN04= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joseph Qi , Baokun Li , Zhang Yi , Jan Kara , Theodore Tso , stable@kernel.org, Sasha Levin Subject: [PATCH 5.10 469/491] ext4: fix iloc.bh leak in ext4_fc_replay_inode() error paths Date: Mon, 13 Apr 2026 18:01:54 +0200 Message-ID: <20260413155836.601669574@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Baokun Li [ Upstream commit ec0a7500d8eace5b4f305fa0c594dd148f0e8d29 ] During code review, Joseph found that ext4_fc_replay_inode() calls ext4_get_fc_inode_loc() to get the inode location, which holds a reference to iloc.bh that must be released via brelse(). However, several error paths jump to the 'out' label without releasing iloc.bh: - ext4_handle_dirty_metadata() failure - sync_dirty_buffer() failure - ext4_mark_inode_used() failure - ext4_iget() failure Fix this by introducing an 'out_brelse' label placed just before the existing 'out' label to ensure iloc.bh is always released. Additionally, make ext4_fc_replay_inode() propagate errors properly instead of always returning 0. Reported-by: Joseph Qi Fixes: 8016e29f4362 ("ext4: fast commit recovery path") Signed-off-by: Baokun Li Reviewed-by: Zhang Yi Reviewed-by: Jan Kara Link: https://patch.msgid.link/20260323060836.3452660-1-libaokun@linux.alibaba.com Signed-off-by: Theodore Ts'o Cc: stable@kernel.org Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- fs/ext4/fast_commit.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) --- a/fs/ext4/fast_commit.c +++ b/fs/ext4/fast_commit.c @@ -1480,19 +1480,21 @@ static int ext4_fc_replay_inode(struct s /* Immediately update the inode on disk. */ ret = ext4_handle_dirty_metadata(NULL, NULL, iloc.bh); if (ret) - goto out; + goto out_brelse; ret = sync_dirty_buffer(iloc.bh); if (ret) - goto out; + goto out_brelse; ret = ext4_mark_inode_used(sb, ino); if (ret) - goto out; + goto out_brelse; /* Given that we just wrote the inode on disk, this SHOULD succeed. */ inode = ext4_iget(sb, ino, EXT4_IGET_NORMAL); if (IS_ERR(inode)) { jbd_debug(1, "Inode not found."); - return -EFSCORRUPTED; + inode = NULL; + ret = -EFSCORRUPTED; + goto out_brelse; } /* @@ -1508,13 +1510,14 @@ static int ext4_fc_replay_inode(struct s ext4_inode_csum_set(inode, ext4_raw_inode(&iloc), EXT4_I(inode)); ret = ext4_handle_dirty_metadata(NULL, NULL, iloc.bh); sync_dirty_buffer(iloc.bh); +out_brelse: brelse(iloc.bh); out: iput(inode); if (!ret) blkdev_issue_flush(sb->s_bdev, GFP_KERNEL); - return 0; + return ret; } /*